boost_system is omitted in build process when needed

Bug #1265668 reported by Sean Ryan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ember
Fix Released
High
Erik Ogenvik

Bug Description

While running "hammer.sh build ember" I get the following error.

/usr/bin/ld: Application.o: undefined reference to symbol '_ZN5boost6system15system_categoryEv'
/usr/lib/x86_64-linux-gnu/libboost_system.so.1.53.0: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
make[3]: *** [ember.bin] Error 1
make[2]: *** [all-recursive] Error 1
make[1]: *** [all] Error 2
make: *** [all-recursive] Error

Actually using mint 16 64 (which is based on the below ubuntu version, nearly identical except for the desktop env)
NAME="Ubuntu"
VERSION="13.10, Saucy Salamander"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 13.10"
VERSION_ID="13.10"
HOME_URL="http://www.ubuntu.com/"
SUPPORT_URL="http://help.ubuntu.com/"
BUG_REPORT_URL="http://bugs.launchpad.net/ubuntu/"

I just tested to correct it by:

src/main/Makefile.am:66 and added -lboost_system to the emberlibs and it built fine (right after the BOOST_THREAD_LIBS inclusion). I wouldn't recommend this as a fix ... I would suggest that the AX_BOOST macro be modified or also include more than the BOOST_THREAD_LIBS or perhaps a better m4 macro be used.

What I do in the metaserver is a check like this in the configure.ac( which automatically puts the -lboost_system as needed ):
AC_CHECK_LIB(boost_system, main, , [
        AC_MSG_ERROR("Linking against boost::system library failed.")
])

I'm unsure of the exact details on it the autoconf/automake primaries and secondaries involved, but I get the -lboost_system for everything (which may or may not be good for ember). I would think that if you define the _LDADD secondary (ie ember_bin_LDADD=...) that might not be an issue.

Revision history for this message
Sean Ryan (sryan) wrote :
Revision history for this message
Sean Ryan (sryan) wrote :

FYI, this was a checkout of hammer from 01/02/2014 @ noon ish.

Revision history for this message
Erik Ogenvik (erik-ogenvik) wrote :

I've updated the macro that we use to detect boost, as per https://blueprints.launchpad.net/ember/+spec/ember-boost-m4-macros
Does this fix the issue?

Changed in ember:
assignee: nobody → Erik Ogenvik (erik-ogenvik)
importance: Undecided → High
status: New → In Progress
Revision history for this message
Sean Ryan (sryan) wrote : Re: [Bug 1265668] Re:boost_system is omitted in build process when needed

Built fine.

On 2014-01-04 16:48, Erik Ogenvik wrote:
> I've updated the macro that we use to detect boost, as per
> https://blueprints.launchpad.net/ember/+spec/ember-boost-m4-macros
> Does this fix the issue?
>
> ** Changed in: ember
> Importance: Undecided => High
>
> ** Changed in: ember
> Status: New => In Progress
>
> ** Changed in: ember
> Assignee: (unassigned) => Erik Ogenvik (erik-ogenvik)
>
> --
> You received this bug notification because you are subscribed to the
> bug
> report.
> https://bugs.launchpad.net/bugs/1265668
>
> Title:
> boost_system is omitted in build process when needed
>
> Status in The Worldforge Ember client:
> In Progress
>
> Bug description:
>
> While running "hammer.sh build ember" I get the following error.
>
> /usr/bin/ld: Application.o: undefined reference to symbol
> '_ZN5boost6system15system_categoryEv'
> /usr/lib/x86_64-linux-gnu/libboost_system.so.1.53.0: error adding
> symbols: DSO missing from command line
> collect2: error: ld returned 1 exit status
> make[3]: *** [ember.bin] Error 1
> make[2]: *** [all-recursive] Error 1
> make[1]: *** [all] Error 2
> make: *** [all-recursive] Error
>
>
> Actually using mint 16 64 (which is based on the below ubuntu
> version, nearly identical except for the desktop env)
> NAME="Ubuntu"
> VERSION="13.10, Saucy Salamander"
> ID=ubuntu
> ID_LIKE=debian
> PRETTY_NAME="Ubuntu 13.10"
> VERSION_ID="13.10"
> HOME_URL="http://www.ubuntu.com/"
> SUPPORT_URL="http://help.ubuntu.com/"
> BUG_REPORT_URL="http://bugs.launchpad.net/ubuntu/"
>
> I just tested to correct it by:
>
> src/main/Makefile.am:66 and added -lboost_system to the emberlibs and
> it built fine (right after the BOOST_THREAD_LIBS inclusion). I
> wouldn't recommend this as a fix ... I would suggest that the
> AX_BOOST
> macro be modified or also include more than the BOOST_THREAD_LIBS or
> perhaps a better m4 macro be used.
>
> What I do in the metaserver is a check like this in the
> configure.ac( which automatically puts the -lboost_system as needed ):
> AC_CHECK_LIB(boost_system, main, , [
> AC_MSG_ERROR("Linking against boost::system library failed.")
> ])
>
> I'm unsure of the exact details on it the autoconf/automake primaries
> and secondaries involved, but I get the -lboost_system for everything
> (which may or may not be good for ember). I would think that if you
> define the _LDADD secondary (ie ember_bin_LDADD=...) that might not
> be
> an issue.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ember/+bug/1265668/+subscriptions

Changed in ember:
status: In Progress → Fix Committed
Changed in ember:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.