Allow a VERP "bounces_ratio" of 0
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
Low
|
Aaron Wells |
Bug Description
Our VERP bounce system has two parameters to determine when to disable someone's email. The absolute number of bounces must be greater than "bounces_min", and the ratio of bounces received versus emails sent, must be greater than "bounces_ratio".
The problem is, on mahara.org we have some email addresses that have received thousands of emails, and others that have received less than a dozen. This makes the bounces_ratio feature not that useful; if we set it something like the default 0.2, then an email address that has been registered for years but has recently become invalid, will have to send us hundreds of bounce messages before we disable it.
So, I want to disable the bouncesratio feature, by setting it to 0 (so that no matter what the ratio of sent to bounced is, it'll be higher than 0). However, check_overcount() short-circuits if *either* bounces_min or bounces_ratio is false, so I can't use 0 because it evaluates to false.
Changed in mahara: | |
status: | In Progress → Fix Committed |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
https:/ /reviews. mahara. org/2803