[gutsy] liferea 1.4rc1 search folders broken

[Fabien Tassin]

Binary package hint: liferea

since 1.4rc1, liferea's search folders are broken. They are no longer matching anything, using the same rules as before (1.1.* and 1.2.*).

[Fabien Tassin (fta)]

"Search Folders" are still broken in 1.4r3

[Jérôme Guelfucci (jerome-guelfucci-deactivatedaccount)]

Thank you for your bug report. I'm marking this as triaged and will forward upstream.

[Jérôme Guelfucci (jerome-guelfucci-deactivatedaccount)]

Upstream answer :

"I cannot reproduce this, I have working search folders with 1.4-RC3 and
know of other users without problems."

Can you give us a not working rule with some example of feeds ?

[Jérôme Guelfucci (jerome-guelfucci-deactivatedaccount)]

Other upstream request :

"Please retest with new release 1.4.0!"

[Jérôme Guelfucci (jerome-guelfucci-deactivatedaccount)]

I'm marking this as confirmed as Greg K Nicholson can reproduce this with liferea 1.4.2. Could you give an example of rule that doesn't work. This could be an Ubuntu specific bug has upstream has no problems with this.

[Grey Nicholson (greytheearthling)]

Absolutely any rule produces zero matches for me.

I have a search folder whose criteria are:
Read status is unread
Flag status is flagged
Update status is updated

Even though several feeds have unread items, there are no matches in the search folder. (Matching any single criterion should be enough to include an item.)

I've also made several new search folders using single criteria such as “Item does contain ‘ubuntu’” and “Item title matches ‘firefox’”—none of them matches any item.

This is using liferea 1.4.2 on gutsy.

[Emilio Pozuelo Monfort (pochu)]

It seems that the Search Folder is created fine, and the rules are there and working.
The problem seems to be that they aren't updated after it's created.

However, if you close Liferea, and restart it, the Search Folders will then display the results correctly.

Could you please verify that?

I've reported this upstream.

[Grey Nicholson (greytheearthling)]

After closing and restarting liferea, the search folder's still empty.

I used Subscriptions → Quit, so it wasn't just hidden in the notification area. Even a full system shutdown-and-restart doesn't make the search folder update itself.

[Emilio Pozuelo Monfort (pochu)]

Fixed in trunk, to be released in 1.4.4.

I'll either get this with 1.4.4 or as a patch, if the former isn't possible / reasonable.

[Grey Nicholson (greytheearthling)]

Will this be fixed before the Gutsy release?

This is a major regression in functionality versus Feisty, that renders a basic feature of Liferea completely unusable, and has a fix available upstream.

[Emilio Pozuelo Monfort (pochu)]

1.4.4 was uploaded yesterday, so yes, this will be fixed for Gutsy.

[Emilio Pozuelo Monfort (pochu)]

liferea (1.4.4-0ubuntu1) gutsy; urgency=low

  * New upstream release. (LP: #125896, #127789).
     - Removing deprecated "Encoding" entry from
       .desktop file (Luis Rodrigo Gallardo Cruz)
     - Fixed warnings/errors with "gecko" as program
       name. Now the correct name "liferea" is used.
     - Fixes assertion when cancelling feed updates
       using the update monitor dialog. (reported
       by caccolangrifata and Aleksei Miheev)
     - Fixes Debian #443751: Tries to run scripts
       to retrieve favicons (reported by Daniel
       Jacobowitz)
     - Fixes SF #1803072: Search folders broken
     - Fixes vertical/horizontal pane position saving
       when exiting Liferea while the mainwindow is
       not visible. (Keith Curtis)
  * upload ok'd by Steve Langasek
  * debian/rules:
    - Use dh_icons instead of dh_iconcache.

 -- Emilio Pozuelo Monfort <email address hidden> Mon, 01 Oct 2007 18:48:33 +0200

[Emilio Pozuelo Monfort (pochu)]

liferea (1.4.4-0ubuntu2) gutsy; urgency=low

  * debian/patches/10_from_upstream_fixes_lp_151217.dpatch:
    Added, fixes a crash when adding a local feed (Add Subscription>Advanced
    Local file>Select file. LP: #151217.

liferea (1.4.4-0ubuntu1) gutsy; urgency=low

  * New upstream release. (LP: #125896, #127789).
     - Removing deprecated "Encoding" entry from
       .desktop file (Luis Rodrigo Gallardo Cruz)
     - Fixed warnings/errors with "gecko" as program
       name. Now the correct name "liferea" is used.
     - Fixes assertion when cancelling feed updates
       using the update monitor dialog. (reported
       by caccolangrifata and Aleksei Miheev)
     - Fixes Debian #443751: Tries to run scripts
       to retrieve favicons (reported by Daniel
       Jacobowitz)
     - Fixes SF #1803072: Search folders broken
     - Fixes vertical/horizontal pane position saving
       when exiting Liferea while the mainwindow is
       not visible. (Keith Curtis)
  * upload ok'd by Steve Langasek
  * debian/rules:
    - Use dh_icons instead of dh_iconcache.

 -- Emilio Pozuelo Monfort <email address hidden> Wed, 10 Oct 2007 20:44:29 +0200

[Fabien Tassin (fta)]

Sorry to re-open this but it's not really fixed.

All my existing search folders are still showing up empty.
If I create a new one with 1 rule, it works
if I add a 2nd rule to this new search folder, it becomes empty
if the 2nd rule is identical to the 1st one, it works

so my guess is that there is a logical AND applied between rules, instead of an OR like before 1.4*.
That makes the Search Folder Properties UI weird to me, and the whole stuff pretty much useless.

[Emilio Pozuelo Monfort (pochu)]

Reopening, thanks Fabien for the testcase.

[Emilio Pozuelo Monfort (pochu)]

Forwarded upstream.

[Grey Nicholson (greytheearthling)]

I can confirm comment 14: the rules appear to be ANDed. These rule-sets demonstrate:

1. Read status is unread
2. Read status is unread; Item does contain “Ubuntu”.

Rule-set 2 returns fewer results than rule-set 1.

(The following is probably a separate bug, but one that exacerbates this:)

The UI isn't very clear on whether the rules *should* be ANDed or OR'd: “Note: items are added to the search folder if at least one additive rule matches. They are removed if at least one removing rule matches.” —it's not made clear which rules are “additive” and which are “removing”.

In fact, the Remove button next to each rule may give the impression that they're all “removing”; a user might try to change a rule to being an “additive” rule by clicking the Remove button, and accidentally delete the rule.

[savebart (savebart)]

For me the problem is the following:

every additional additive rule behaves as a removing rule.

For this reason when I have only one rule the search works fine, if I add a rule more the search results decrease significantly.

[Emilio Pozuelo Monfort (pochu)]

Fixed in 1.4.7

[Emilio Pozuelo Monfort (pochu)]

liferea (1.4.7-0ubuntu1) hardy; urgency=low

  * New upstream release. LP: #154727, #156303, #141158, LP: #134086,
    LP: #125896.
  * debian/control: change liblua50-dev to liblualib50-dev, so configure
    recognizes LUA50. This builds the Script Manager. LP: #158422.
  * debian/patches/10_from_upstream_fixes_lp_151217.dpatch,
    debian/patches/20_from_upstream_fix_sql_join_lp_141155.dpatch,
    debian/patches/30_from_upstream_workaround_data_loss_lp_138208.dpatch:
    - Removed, fixed upstream.

  * Merge from Debian unstable, remaining Ubuntu changes:
    - debian/control:
      + Added firefox-dev and intltool to build-deps.
      + Removed libxul-dev and libwebkitgtk-dev from build-deps.
      + Build-depend on liblualib50-dev instead of liblua5.1-0-dev.
      + Changed Maintainer field to match DebianMaintainerSpec.
      + Added firefox to liferea dependencies.
      + Do not build transitional packages (not required due to Conflicts/
        Provides/Replaces).
      + Do not build webkit package.
    - debian/rules:
      + Call intltool-update -p to generate translation template for Rosetta
      + Don't disable gecko, and don't enable xulrunner and webkit.
    - debian/liferea-webkit.files:
      + Not needed. We don't build the webkit rendering plugin.

liferea (1.4.6-1) unstable; urgency=low

  * New upstream releases.
   1.4.5b:
   - Fixes use of sqlite3_free, avoiding crashing when using with sqlite
    3.5 (Closes: #446050).

   1.4.6:
   - No longer segfaults when selecting empty folder (Closes: #445457).
   - Fixes loss of customized feed titles (Closes: #443413).
   - Various other bug fixes not reported in Debian, see upstream changelog.

  * debian/control:
   - Correct typo in liferea-webkit description (Closes: #446109).
   - Remove XS- prefix from Vcs-* fields.
   - Move Homepage from description into propper field.

liferea (1.4.5-1) unstable; urgency=low

  * New upstream releases.
   1.4.3b:
   - Better handling of extra XML namespaces (Closes: #430782).
   - Avoid dropping flagged items from the cache (Closes: #442811, #443427).

   1.4.4:
   - Fixes assertion when cancelling feed updates using the update monitor
     dialog.
   - No longer tries to run scripts to retrieve favicons (Closes: #443751).
   - Reduces minimum window size (Closes: #434866).

   1.4.5:
   - Fixes crash when using "Select File" from the advanced subscribtion
    dialog (Closes: #445387).
   - Close and reopen database every 500 write attempts, to work around
    data loss on unclean termination (Closes: #445666).
   - Adapt WebKit plugin to renamed function names.

  * debian/rules: Add call to dh_icons, to register program icons with the
   Gtk icon cache. Thanks to Emilio Pozuelo Monfort for the suggestion.
  * debian/control: Update build-depends to libwebkitgtk-dev, the new name
    of the WebKit package.

 -- Emilio Pozuelo Monfort <email address hidden> Mon, 29 Oct 2007 23:14:45 +0100