OpenStack Dashboard (Horizon)

Angular not loaded on modals

Bug #1258192 reported by Maxime Vidori on 2013-12-05

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Dashboard (Horizon)	Fix Released	High	Maxime Vidori	OpenStack Dashboard (Horizon) 2014.1 "icehouse"

Bug Description

The angular cycle is not started when an element is added to the DOM outside of angular. This happen especially when a modal is called, due to the asynchronous insertion, angular does not know that the DOM as changed.

See original description

Maxime Vidori (maxime-vidori) on 2013-12-05

description:

updated

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-12-05: Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/60268

Changed in horizon:
assignee:	nobody → Maxime Vidori (maxime-vidori)
status:	New → In Progress

David Lyle (david-lyle) on 2013-12-05

Changed in horizon:
importance:	Undecided → High
milestone:	none → icehouse-2

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-12-11: Fix merged to horizon (master)

Reviewed: https://review.openstack.org/60268
Committed: http://github.com/openstack/horizon/commit/4b528b3c1509ba5ffbd22262d43a3858c30b25ae
Submitter: Jenkins
Branch: master

commit 4b528b3c1509ba5ffbd22262d43a3858c30b25ae
Author: Maxime Vidori <email address hidden>
Date: Thu Dec 5 16:24:27 2013 +0100

Add a loadAngular function

        If something is added to the DOM with external tools, angular is not
    aware of these changes (Ajax call, pure js DOM manipulation, etc...).
    This patch add an utility function which will load angular on the given
    element.
        There is also an example on modal, angular is now loaded when a
    modal is shown.

Fixes bug #1258192

Change-Id: I3266b455d79d7d1856e4a622e927ed4af8e90b5e