elementary-tweaks depends on pantheon-files gsettings schema

Bug #1257033 reported by dkotrada
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Elementary Community
Confirmed
Undecided
Unassigned

Bug Description

sudo apt-get purge pantheon-files, then start switchboard and click on tweaks. Only loading icon is visible.

dkotrada (dkotrada)
summary: - elementary-tweaks doesn't load when purge pantheon-files
+ elementary-tweaks doesn't load when purged pantheon-files
Revision history for this message
Benedikt Schlagberger (benedikt-8) wrote : Re: elementary-tweaks doesn't load when purged pantheon-files
quequotion (quequotion)
summary: - elementary-tweaks doesn't load when purged pantheon-files
+ elementary-tweaks depends on pantheon-files gsettings schema
Revision history for this message
quequotion (quequotion) wrote :

Changed title to be more specific.

There are a couple of these bugs at the moment. They wouldn't be noticed by users of Elementary OS: only users who have installed some /parts/ of the elementary suite will encounter them.

In this case, installing elementary-tweaks but not pantheon-files.

Revision history for this message
quequotion (quequotion) wrote :

This bug comes from code in /src/Settings/FilesSettings.vala:

http://bazaar.launchpad.net/~versable/elementary-community/elementary-tweaks/view/head:/src/Settings/FilesSettings.vala

The problem is similar bug 1255665; the code doesn't handle the case of Files not being installed.

I would offer the same three proposals as in bug 1255665, but I think this bug makes a stronger case for options 1 (handle unavailability) or 2 (add a dependency) than 0 (remove the toggles).

In this case the package involved is Elementary-specific. It would be reasonable to make elementary-tweaks depend on pantheon-files in packaging (option 2). However, it would make elementary-tweaks more useful, if it could still be used without Files installed by dynamically loading without File's toggles or with the toggles disabled (option 1).

Since it's likely that one of these bug reports could be made for every software package with settings that elementary-tweaks can manipulate, I think it would be of most benefit to add code to elementary-tweaks to handle the absence of those packages rather than adding dependencies for each of them.

quequotion (quequotion)
Changed in elementary-community:
status: New → Confirmed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related questions

Remote bug watches

Bug watches keep track of this bug in other bug trackers.