Enabled group-per-window setting causes dconf write on each window switch

Bug #1256559 reported by Oleg O Andreev
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Indicator keyboard
Fix Released
Undecided
Unassigned
indicator-keyboard (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

When group-per-window option is enabled, each time active window is switched "org.gnome.desktop.input-sources.current" key is updated by indicator-keyboard-service. This key is updated even if it has previously stored the same value.

Update causes dconf-service to write the user config file ~/.config/dconf/user to disk. On all filesystems except btrfs this write is followed by fsync. which causes immediate disk activity upon each window switch.

It would be nice if indicator-keyboard did not update the "org.gnome.desktop.input-sources.current" with the same value.

A simple patch with the proposed solution is attached to this bug report.

Related branches

Revision history for this message
Oleg O Andreev (olegoandreev) wrote :
Revision history for this message
William Hua (attente) wrote :

Hi Oleg, thanks for your patch! I modified it only slightly since trunk has changed a bit, but your patch still looks good.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package indicator-keyboard - 0.0.0+14.04.20140227.3-0ubuntu1

---------------
indicator-keyboard (0.0.0+14.04.20140227.3-0ubuntu1) trusty; urgency=low

  [ Sebastien Bacher ]
  * Drop unity8 test description, that indicator is used on desktop only

  [ William Hua ]
  * Do not set org.gnome.desktop.input-sources.current when unchanged
    (LP: #1256559). (LP: #1256559)
  * Update icons when icon theme changes. (LP: #1237749)

  [ Ubuntu daily release ]
  * New rebuild forced
 -- Ubuntu daily release <email address hidden> Thu, 27 Feb 2014 19:38:10 +0000

Changed in indicator-keyboard (Ubuntu):
status: New → Fix Released
William Hua (attente)
Changed in indicator-keyboard:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.