alarm-threshold-update cannot update generic alarm attributes

[Eoghan Glynn]

Generic (i.e. non-threshold-related) alarm attributes cannot be updated with the alarm-threshold-update command, for example:

  $ ceilometer --debug alarm-threshold-update -a $ALARM_ID --repeat-actions True
  INFO (connectionpool:176) Starting new HTTP connection (1): 192.168.122.73
  DEBUG (connectionpool:344) "POST /v2.0/tokens HTTP/1.1" 200 9905
  'threshold_rule'

The non-update is not properly reported, i.e. the failure is semi-silent.

This is inconsistent with the help message for the command that implies all attributes can be updated, also with the behavior of alarm-combination-update.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/57903

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/57903
Committed: http://github.com/openstack/python-ceilometerclient/commit/08b476d2c9edeff7d025038467922f3d1cda6f19
Submitter: Jenkins
Branch: master

commit 08b476d2c9edeff7d025038467922f3d1cda6f19
Author: Eoghan Glynn <email address hidden>
Date: Fri Nov 22 11:18:35 2013 +0000

    Allow alarm-threshold-update to upate generic attributes

    Fixes bug 1253989

    Previously, generic (i.e. non-threshold-related) alarm attributes could
    not be updated with the alarm-threshold-update command. An attempt to
    do so failed semi-silently when a non-existent dict key was referenced.

    Now, all alarm attributes can be updated with this command.

    Change-Id: Iba3f21de879fb853575dcec1730de7873eab8afd