Wrong description of UI tests setup in development documentation for nailgun
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Fuel for OpenStack |
Fix Released
|
High
|
Fuel UI Team |
Bug Description
There is a problem with development documentation for nailgun:
https:/
UI tests setup was checked within https:/
and no appropriate solution was found to get jslint tests green.
In Ubuntu Server 12.04 jslint tests didn't even run until nodejs upgrade:
sudo apt-get install python-
sudo add-apt-repository -y ppa:chris-
sudo apt-get update
sudo apt-get install nodejs
But there was no appropriate solution found to get jslint tests green (for both 12.04 and 13.04).
jslint output:
$ ./run_tests.sh --jslint
static/js/utils.js
#1 Unused 'dummy'.
var dummy = this.offsetHeight; // Line 44, Pos 25
static/js/models.js
#1 Expected 'ignore' and instead saw 'e'.
} catch (e) {} // Line 136, Pos 22
#2 Expected 'ignore' and instead saw 'e'.
} catch(e) {} // Line 199, Pos 21
#3 Unused 'options'.
toJSON: function(options) { // Line 208, Pos 26
#4 Unused 'collections'.
var collections = {}; // Line 20, Pos 9
static/js/main.js is OK.
static/
static/
#1 Unexpected assignment expression.
this.
static/
#1 Unexpected assignment expression.
this.
static/
#1 Expected 'ignore' and instead saw 'e'.
} catch(e) {} // Line 59, Pos 21
#2 Unused 'cluster'.
beforeClust
#3 Unused 'cluster'.
beforeSetti
#4 Unused 'model'.
this.
#5 Unused 'e'.
renderReleases: function(e) { // Line 300, Pos 34
#6 Expected 'ignore' and instead saw 'e'.
} catch(e) {} // Line 352, Pos 21
#7 Unused 'response'.
.done(
#8 Expected 'ignore' and instead saw 'e'.
} catch (e) {} // Line 641, Pos 26
#9 Expected 'ignore' and instead saw 'e'.
} catch (e) {} // Line 668, Pos 26
#10 Unused 'options'.
this.
#11 Unused 'deferred'.
var deferred = this.nodes.
static/
#1 Unexpected assignment expression.
this.
static/
#1 Unused 'breadcrumbsPath'.
var breadcrumbsPath = _.isFunction(
#2 Unused 'e'.
togglePopover: function(e) { // Line 144, Pos 33
#3 Unused 'options'.
initialize: function(options) { // Line 269, Pos 30
#4 Unused 'model'.
this.
static/
static/
#1 Unused 'models'.
function(
static/
#1 Unused 'options'.
initialize: function(options) { // Line 249, Pos 30
#2 Unused 'models'.
function(utils, models, commonViews, dialogViews, NodesTab, NetworkTab, SettingsTab, LogsTab, ActionsTab, HealthCheckTab, clusterPageTemp
static/
#1 Unused 'el'.
this.
#2 Unused 'index'.
this.
#3 Unused 'model'.
this.
#4 Unused 'e'.
onChange: function(e) { // Line 418, Pos 28
#5 Unused 'model'.
this.
#6 Unused 'e'.
changeConfi
#7 Unused 'model'.
this.
#8 Unused 'dialogViews'.
function(utils, models, commonViews, dialogViews, networkTabTemplate, networkTemplate, novaNetworkConf
etc.
Appropriate solution is required to get UI tests green (for Ubuntu 12.04, and *maybe* 13.04-13.10).
Changed in fuel: | |
assignee: | Vitaly Kramskikh (vkramskikh) → Fuel UI Team (fuel-ui) |
Changed in fuel: | |
status: | Fix Committed → Fix Released |
Fixed a few weeks ago by switching to JS dependencies management using npm/grunt/bower