flavors extra spec captured value too short

Bug #1252427 reported by Philippe Chevallier
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Zhenguo Niu

Bug Description

The capture field in the flavor extra spec form, is currently set to 25, but should be bumped up to 37 to accommodate the entire ID length.

../openstack_dashboard/dashboards/admin/flavors/extras/forms.py:

class EditExtraSpec(forms.SelfHandlingForm):
    key = forms.CharField(max_length="25", label=_("Key"))
    value = forms.CharField(max_length="37", label=_("Value"))
    flavor_id = forms.CharField(widget=forms.widgets.HiddenInput)

Should be
    value = forms.CharField(max_length="37", label=_("Value"))

same in the "create" extra spec window:
class CreateExtraSpec(forms.SelfHandlingForm):
    key = forms.CharField(max_length="25", label=_("Key"))
    value = forms.CharField(max_length="37", label=_("Value"))
    flavor_id = forms.CharField(widget=forms.widgets.HiddenInput)

Revision history for this message
Philippe Chevallier (philippe-r) wrote :
Changed in horizon:
status: New → Confirmed
assignee: nobody → Zhenguo Niu (niu-zglinux)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/57088

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/57088
Committed: http://github.com/openstack/horizon/commit/da7a06160691d8cebd7924663e97cd1eba5f8b66
Submitter: Jenkins
Branch: master

commit da7a06160691d8cebd7924663e97cd1eba5f8b66
Author: Zhenguo Niu <email address hidden>
Date: Tue Nov 19 10:57:42 2013 +0800

    Bumping up max_length of flavor extra spec.

    The capture field in the flavor extra spec form, is currently set to 25,
    but should be bumped up to accommodate some long values.

    Change-Id: I54a12b01222faf0d7dd32768c73f192e3d3cf8e1
    Fixes: bug #1252427

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
milestone: none → icehouse-1
importance: Undecided → Low
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.