remote.py is hard-coding the credentials of radmin along with authtoken while creating heatclient

Bug #1251203 reported by Sushil Kumar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Undecided
Sushil Kumar

Bug Description

Method trove.common.remote.heat_client is hardcoding the credentials of radmin, which is not required since we are using authtoken to authenticate.

We should remove radmin credentials, as it is not required.
It should not be used as context should be of the user who is calling the trove-client, but this code hard-codes the username and password to radmin always irrespective of context.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/56373

Changed in trove:
assignee: nobody → Sushil Kumar (sushil-kumar2)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/56373
Committed: http://github.com/openstack/trove/commit/0eb28e89a5c5453a8337e031dd71a5019d828aab
Submitter: Jenkins
Branch: master

commit 0eb28e89a5c5453a8337e031dd71a5019d828aab
Author: Sushil Kumar <email address hidden>
Date: Thu Nov 14 11:52:14 2013 +0000

    Remove radmin credentials from create_heat_client

    auth_token is enough for authentication
    in creating a heatclient.Client instance.

    Currently both username/password and auth_token
    are passed as argument in create_heat_client

    Fixes: Bug 1251203

    Change-Id: I3cce6b35fc40f4ff4cc45b04714067956fb1869d

Changed in trove:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in trove:
milestone: none → icehouse-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.