View gives error if user could make skins then had option revoked

Bug #1250235 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Robert Lyon

Bug Description

When viewing the page see errors like this
[WAR] 60 (view/view.php:321) Undefined variable: skindata
Call stack (most recent first):

    log_message("Undefined variable: skindata", 8, true, true, "/home/robertl/htdocs/mahara-devel/mahara/htdocs/vi...", 321) at /home/robertl/htdocs/mahara-devel/mahara/htdocs/lib/errors.php:430
    error(8, "Undefined variable: skindata", "/home/robertl/htdocs/mahara-devel/mahara/htdocs/vi...", 321, array(size 90)) at /home/robertl/htdocs/mahara-devel/mahara/htdocs/view/view.php:321

The check is checking on the wrong variable

will make a patch to fix

Revision history for this message
Robert Lyon (robertl-9) wrote :
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/2696
Committed: http://gitorious.org/mahara/mahara/commit/61538092deb07240218de5c72a5833b5dd08d023
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 61538092deb07240218de5c72a5833b5dd08d023
Author: Robert Lyon <email address hidden>
Date: Tue Nov 12 11:28:35 2013 +1300

Doing better check on whether a skin is being used (bug #1250235)

was checkoing on $viewskin var rather than the $skin var set if allowed to
have skin on page

Change-Id: I6199f80f849dce1970b67f77f7638345bdb4679e
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.