Users who are in "No Institution" can't use skins
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
High
|
Son Nguyen | ||
1.8 |
Fix Released
|
High
|
Unassigned | ||
1.9 |
Fix Released
|
High
|
Son Nguyen |
Bug Description
To replicate:
1. Set $cfg->skins = true;
2. Go to the configuration screen for the default institution ("No Institution")
3. Note that unlike other institutions, there is no skins checkbox displayed
4. Click "Submit" on the configuration screen
5. Log in as a user in the default institution
6. Navigate to their Portfolio section
Expected result: They should have a "Portfolio -> Skins" option.
Actual result: They do not.
The problem is that, although we set institution.skins to 1 by default during installation and upgrade, the absence of the skins checkbox on the default institution's config screen means that it gets set to 0 the first time you save anything on that screen.
Looking at the code, I realize that the reason the skins checkbox is hidden form the default institution was not on purpose, but because the checkbox made the most logical sense placed adjacent to the other theming-related settings, and those all happen to be settings that can't be overridden for the default institution.
Changed in mahara: | |
status: | In Progress → Fix Committed |
Changed in mahara: | |
status: | Fix Committed → In Progress |
Changed in mahara: | |
status: | In Progress → Fix Committed |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
I think we should probably move this setting into the configurable area for "No Institution". On the other hand, it may be worth revisiting what the rationale was for hiding so many other options from "No Institution". Perhaps that same rationale applies to skins?