Oslo.messaging.notifier hangs while sending notifications

[Christian Strack]

Oslo.messaging.notify.Notifier uses oslo.messaging.Transport as an interface for different transport drivers. The method oslo.messaging.Transport.send_notifications calls the driver method send which has a different signature than send_notification. Thus, the version number gets used as wait_for_reply flag and the whole notification process hangs while waiting for a reply.

Fix:
--- a/oslo/messaging/transport.py
+++ b/oslo/messaging/transport.py
@@ -91,7 +91,7 @@ class Transport(object):
         if not target.topic:
             raise exceptions.InvalidTarget('A topic is required to send',
                                            target)
- self._driver.send(target, ctxt, message, version)
+ self._driver.send_notification(target, ctxt, message, version)

     def _listen(self, target):
         if not (target.topic and target.server):

[Davanum Srinivas (DIMS) (dims-v)]

Christian,

Can you please submit a gerritt review?

https://wiki.openstack.org/wiki/How_To_Contribute#If_you.27re_a_developer
https://wiki.openstack.org/wiki/Gerrit_Workflow

thanks,
dims

[Christian Strack (abyth)]

Hey Dims,

here is the requested workflow, at least i hope so:
https://review.openstack.org/#/c/54718/

Greetings
Christian
--
Christian Strack, M.Sc.

Distributed Systems Group
Department of Mathematics & Computer Science
Philipps-Universität Marburg, Germany

Phone: [phone]
Fax: [phone]
E-mail: <email address hidden>

Am 31.10.2013 um 12:00 schrieb Davanum Srinivas (DIMS) <email address hidden>:

> Christian,
>
> Can you please submit a gerritt review?
>
> https://wiki.openstack.org/wiki/How_To_Contribute#If_you.27re_a_developer
> https://wiki.openstack.org/wiki/Gerrit_Workflow
>
> thanks,
> dims
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1246621
>
> Title:
> Oslo.messaging.notifier hangs while sending notifications
>
> Status in Messaging API for OpenStack:
> New
>
> Bug description:
> Oslo.messaging.notify.Notifier uses oslo.messaging.Transport as an
> interface for different transport drivers. The method
> oslo.messaging.Transport.send_notifications calls the driver method
> send which has a different signature than send_notification. Thus, the
> version number gets used as wait_for_reply flag and the whole
> notification process hangs while waiting for a reply.
>
> Fix:
> --- a/oslo/messaging/transport.py
> +++ b/oslo/messaging/transport.py
> @@ -91,7 +91,7 @@ class Transport(object):
> if not target.topic:
> raise exceptions.InvalidTarget('A topic is required to send',
> target)
> - self._driver.send(target, ctxt, message, version)
> + self._driver.send_notification(target, ctxt, message, version)
>
> def _listen(self, target):
> if not (target.topic and target.server):
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/oslo.messaging/+bug/1246621/+subscriptions