OpenStack DBaaS (Trove)

Invalid checksum for backup produces bad error message

Bug #1246368 reported by Tim Simpson on 2013-10-30

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack DBaaS (Trove)	Fix Released	Undecided	Tim Simpson	OpenStack DBaaS (Trove) 2014.1 "icehouse"

Bug Description

The code to raise an exception if a checksum can't be verified currently isn't working very well, leading to 500 errors.
At the root of the issue is that the exception initializer references a variable which is undefined.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-10-30: Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/54565

Changed in trove:
assignee:	nobody → Tim Simpson (tim-simpson)
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-11-01: Fix merged to trove (master)

Reviewed: https://review.openstack.org/54565
Committed: http://github.com/openstack/trove/commit/0b6136cdbc9f5299c57e38ada5b69c96db6e79c4
Submitter: Jenkins
Branch: master

commit 0b6136cdbc9f5299c57e38ada5b69c96db6e79c4
Author: Tim Simpson <email address hidden>
Date: Wed Oct 30 10:21:19 2013 -0500

Fix checksum verification exception.

    Previously if an invalid checksum was found, the exception would not be
    raised. This commit also makes the tests for backup run in fake mode
    run again (turns out there was no reason to disable them) since they
    helped find this, and cleans up an issue with the restore backup test
    (it used the current size of an instance created elsewhere for no
    reason).

Fixes bug 1246368

Change-Id: I96a570a93695b017e5c6966fa1482d6ec5aef426