php-wikidiff2: Incorrect PHP short open tag used in wikidiff2.php

Bug #1243119 reported by Anthony Fok
20
This bug affects 4 people
Affects Status Importance Assigned to Milestone
wikidiff2 (Debian)
Fix Released
Unknown
wikidiff2 (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

/etc/mediawiki-extensions/extensions-available/wikidiff2.php uses the deprecated short open tag "<?",
whereas all other extensions use the recommended full open tag "<?php".

This may not have been a problem in the past, but the latest PHP 5.5.3 packages in Ubuntu 13.10 (saucy) (and Debian) now have
"short_open_tag = Off" as the default in the system-wide php.ini files. So, visitors to a local MediaWiki installation would see:

    'Wikidiff2', 'version' => '', 'author' => 'Tim Starling', 'description' => 'external diff engine for MediaWiki', 'url' => 'https://www.mediawiki.org/wiki/Extension:Wikidiff2' ); $wgExternalDiffEngine = 'wikidiff2';

plastered across the top of every MediaWiki page.

This issue was reported as Debian Bug#716995 and Bug#723622 in July and September 2013 respectively.

ProblemType: Bug
DistroRelease: Ubuntu 13.10
Package: php-wikidiff2 0.0.1+svn109581-1build1
ProcVersionSignature: Ubuntu 3.11.0-12.19-generic 3.11.3
Uname: Linux 3.11.0-12-generic x86_64
ApportVersion: 2.12.5-0ubuntu2
Architecture: amd64
Date: Tue Oct 22 16:50:36 2013
InstallationDate: Installed on 2012-12-11 (314 days ago)
InstallationMedia: Ubuntu 12.10 "Quantal Quetzal" - Release amd64 (20121017.5)
MarkForUpload: True
SourcePackage: wikidiff2
UpgradeStatus: Upgraded to saucy on 2013-10-21 (1 days ago)

Revision history for this message
Anthony Fok (foka) wrote :
Changed in wikidiff2 (Debian):
status: Unknown → Confirmed
Revision history for this message
manuel fernandez (mfg) wrote :

Yes, message of wikidiff2 is plastered across the top of every MediaWiki page!

Changed in wikidiff2 (Ubuntu):
status: New → Confirmed
tags: added: bitesize
Raghuram Kota (rkota)
tags: added: hs-arm64
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package wikidiff2 - 0.0.1+svn109581-1ubuntu1

---------------
wikidiff2 (0.0.1+svn109581-1ubuntu1) trusty; urgency=medium

  * Install ini file in correct location with PHP 5.5 (LP: #1243568).
  * debian/etc/mediawiki-extensions/extensions-available/wikidiff2.php:
    + better php open tag (LP: #1243119).
 -- Leo Iannacone <email address hidden> Sat, 22 Feb 2014 12:41:21 +0100

Changed in wikidiff2 (Ubuntu):
status: Confirmed → Fix Released
Changed in wikidiff2 (Debian):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.