ML2 plugin is not loaded properly in TestMl2SGServerRpcCallBack

[Akihiro Motoki]

ML2 plugin is not loaded properly in TestMl2SGServerRpcCallBack.

By grepping a result in .testrepository, test_extension_security_group.SecurityGroupTestPlugin is loaded as a core plugin in ML2 test. It means Ml2 plugin is not tested in this case.

$ OS_DEBUG=1 python setup.py testr --slowest --testr-args='neutron.tests.unit.ml2'
$ grep "Loading Plugin" .testrepository/235 | cut -d ']' -f 2 | cut -d : -f 2 | sort | uniq -c
    835 neutron.plugins.ml2.plugin.Ml2Plugin
     35 neutron.services.l3_router.l3_router_plugin.L3RouterPlugin
     14 neutron.tests.unit.test_extension_security_group.SecurityGroupTestPlugin
    137 neutron.tests.unit.test_l3_plugin.TestL3NatServicePlugin

[Akihiro Motoki (amotoki)]

A problem SecurityGroupTestPlugin is loaded instead of Ml2Plugin will be fixed by a patch https://review.openstack.org/#/c/52834/ . I confirmed the problem is fixed by the patch.

Loading TestL3NatServicePlugin is intentional and it seems make sense.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/52834
Committed: http://github.com/openstack/neutron/commit/31def3ccf425a8f1a617a674a30d29f89d733432
Submitter: Jenkins
Branch: master

commit 31def3ccf425a8f1a617a674a30d29f89d733432
Author: Akihiro MOTOKI <email address hidden>
Date: Fri Oct 18 15:09:29 2013 +0900

    Ensure OVS plugin is loaded in OVS plugin test

    In TestOpenvswitchSGServerRpcCallBack and NetworkBindingsTest
    in OVS plugin tests, OVS plugin was not loaded properly.

    * For NetworkBindingsTest, it can be fixed by changing setUp()
      to take 'plugin' arguments in the base test classes
      SecurityGroupDBTestCase and SGServerRpcCallBackMixinTestCase.
      This fixes bug 1242510 in ML2 unit tests.

    * For NetworkBindingsTest, it can be fixed by passing the plugin
      class to super.setUp(). The test itself needs to be updated
      because network binding is added when a network is created.

    * NetworkBindingsTest in Linux Bridge plugin has the same issue,
      so it is also fixed in this patch.

    Closes-Bug: #1230083
    Closes-Bug: #1242510
    Change-Id: I914876225480585d822748c188e9b69d1adf46f3