xenapi: agent set password fails badly when there is a timeout

Bug #1241738 reported by John Garbutt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
John Garbutt

Bug Description

No agent failures are skipped, the set password fails badly when there is a timeout:

AgentTimeout: Unable to contact guest agent. The following call timed out: key_init

leads to:

in _exchange_key_with_agent
    agent_pub = int(resp)
TypeError: int() argument must be a string or a number, not 'NoneType'

Tags: xenserver
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/52688

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/52688
Committed: http://github.com/openstack/nova/commit/c3aa5583d3539744c3aa104f4b450e45ce298be2
Submitter: Jenkins
Branch: master

commit c3aa5583d3539744c3aa104f4b450e45ce298be2
Author: John Garbutt <email address hidden>
Date: Fri Oct 18 18:48:29 2013 +0100

    xenapi: stop key_init timeout failing set password

    When key-init timeout occurs, it returns None, which causes the
    set-password to fail with an error casting None to int.

    This code ensures it fails silently as intended.

    Fixes bug 1241738
    Change-Id: I080807c5728f94a6b36957efd6f2bbc44a76b1cd

Changed in nova:
status: In Progress → Fix Committed
Changed in nova:
milestone: none → icehouse-1
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.