VMware: Detaching a volume from an instance also deletes the volume's backing vmdk (ESXDriver only)

[Subbu]

I found that when I run:

% nova volume-detach my_instance c54ad11f-4e51-41a0-97db-7e551776db59

where the volume with given id is currently attached to my running instance named my_instance, the operation completes successfully. Nevertheless a subsequent attach of the same volume again will fail. So:

% nova volume-attach my_instance c54ad11f-4e51-41a0-97db-7e551776db59 /dev/sdb

fails with the error that the volume's vmdk file is not found.

Cause:

During volume detach a delete_virtual_disk_spec is used to remove the device from the running instance. This spec also "destroy"s the underlying vmdk file. The offending line is : https://github.com/openstack/nova/blob/master/nova/virt/vmwareapi/vm_util.py#L471

Possible fix:
The fileOperation field of the device config during this reconfigure operation should be left unset. We should continue setting device_config.operation field to "remove". This will remove the device from the VM without deleting the underlying vmdk backing.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/52645

[Guangya Liu (Jay Lau) (jay-lau-513)]

Hi Tracy, just curious what can I do for "VMwareAPI-Team"? ;-) Can you please show more details? Thanks.

[Tracy Jones (tjones-i)]

Jay - this is just a way where we track bugs that are important for our customers. think of this as kind of a tag.

[Subbu (subramanian-neelakantan)]

I found that this problem occurs only when using the VMwareESXDriver and not with the VMwareVCDriver.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/52645
Committed: http://github.com/openstack/nova/commit/0405d7b937fdeece46efc1ba90171163f3286a56
Submitter: Jenkins
Branch: master

commit 0405d7b937fdeece46efc1ba90171163f3286a56
Author: Jay Lau <email address hidden>
Date: Fri Oct 18 22:38:13 2013 +0800

    VMware: Detach volume should not delete vmdk

    During volume detach a delete_virtual_disk_spec is used to remove
    the device from the running instance. This spec also "destroy" the
    underlying vmdk file, this is not right, we should not delete vmdk
    file when detach it from a VM instance.

    The fix was remove the fileOperation field when detach vmdk volume
    so as to make sure the volume will not be destroyed; but for iscsi
    we still need to destroy the volume.

    Also I changed the function name from delete_virtual_disk_spec to
    detach_virtual_disk_spec which is more accurate.

    Change-Id: Ibd218d6a8cfeede4f5ca74f28bc0c3d0c185bb14
    Closes-Bug: #1241350

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/56746

[dan wendlandt (danwent)]

Removing vmwareapi team tag, as this is not relevant for the VCDriver, only relevant for the ESXDriver.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/56746
Committed: http://github.com/openstack/nova/commit/e69310b27bf1c89ac9b971720b62f1cc8268de3c
Submitter: Jenkins
Branch: stable/havana

commit e69310b27bf1c89ac9b971720b62f1cc8268de3c
Author: Jay Lau <email address hidden>
Date: Fri Oct 18 22:38:13 2013 +0800

    VMware: Detach volume should not delete vmdk

    During volume detach a delete_virtual_disk_spec is used to remove
    the device from the running instance. This spec also "destroy" the
    underlying vmdk file, this is not right, we should not delete vmdk
    file when detach it from a VM instance.

    The fix was remove the fileOperation field when detach vmdk volume
    so as to make sure the volume will not be destroyed; but for iscsi
    we still need to destroy the volume.

    Also I changed the function name from delete_virtual_disk_spec to
    detach_virtual_disk_spec which is more accurate.

    Change-Id: Ibd218d6a8cfeede4f5ca74f28bc0c3d0c185bb14
    Closes-Bug: #1241350
    (cherry picked from commit 0405d7b937fdeece46efc1ba90171163f3286a56)