Tags property should be updatable

[Simon Pasquier]

I have a template with a resource like this:

  Instance:
    Type: AWS::EC2::Instance
    Properties:
      ImageId: F19-x86_64
      InstanceType: m1.small
      Tags: [ { "Key": "service", "Value": "foo" } ]

Then I update the template with a new value for Tags:

  Instance:
    Type: AWS::EC2::Instance
    Properties:
      ImageId: F19-x86_64
      InstanceType: m1.small
      Tags: [ { "Key": "service", "Value": "bar" } ]

The Heat engine triggers a deletion/creation of the instance resource.

[Angus Salkeld (asalkeld)]

Just a caution, to test well the interaction with alarms, launch configs and scaling groups.
We probably need to make these consistent if possible.
So should/can they all be updatable?

[Simon Pasquier (simon-pasquier)]

Thanks for the feedback Angus. I guess you're talking about the tags with keys prefixed "metering." so maybe these could be treated separately (if possible?).

FYI this bug report was triggered by bug #1240888 (Resources created during update get invalid AWS::StackId value). My tag value was {Ref: "AWS::StackId"}. Because of that bug, I noticed that tags were not updatable but I didn't dig any further.

[Steve Baker (steve-stevebaker)]

We just need to be careful not to modify tags that weren't/aren't specified by the template

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/56126

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/56127

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/56127
Committed: http://github.com/openstack/heat/commit/e822347a7d5c4619e1ad48a1ce3d66fbf6055f55
Submitter: Jenkins
Branch: master

commit e822347a7d5c4619e1ad48a1ce3d66fbf6055f55
Author: Angus Salkeld <email address hidden>
Date: Sun Nov 17 13:23:19 2013 +1100

    Make instance Tags updatable

    Note: I don't think that there is an issue with autoscaling tags
    as autoscaling drives the instance via the properties and it doesn't
    update intances anyways, it only creates/destroys instances.

    Change-Id: I3cea4180f22690ea226273cc96132db6ae3dde12
    Closes-bug: #1240885