Resources created during update get invalid AWS::StackId value

[Simon Pasquier]

When a resource is created during an update process, the AWS::StackId value is not correct.

{
  "AWSTemplateFormatVersion": "2010-09-09",
  "Description": "",
  "Mappings": {},
  "Outputs": {
  },
  "Parameters": {
    "KeyName": {
      "Description": "Name of an existing EC2 KeyPair to enable SSH access to the instances",
      "Type": "String"
    }
  },
  "Resources": {

    "EC2": {
      "Metadata": {
        "stackid": {"Ref":"AWS::StackId"},
        "stackname": {"Ref":"AWS::StackName"}
      },
      "Properties": {
        "ImageId": "cirros-0.3.1-x86_64-uec",
        "InstanceType": "m1.nano",
        "KeyName": {"Ref": "KeyName"}
     },
     "Type":"AWS::EC2::Instance"
  }
 }
}

$ heat stack-create -f <template> -P "KeyName=test" my-stack
...
$ heat resource-metadata my-stack EC2
{
  "stackid": "arn:openstack:heat::2bc5532bfd3e4263a949d810e6fc4e65:stacks/stack1/13caf13c-504a-4189-9c4a-9442ea58006d",
  "stackname": "stack1"
}
$ heat stack-update -f simple.json -P "KeyName=test2" stack1
...
$ heat resource-metadata stack1 EC2
{
  "stackid": "arn:openstack:heat::2bc5532bfd3e4263a949d810e6fc4e65:stacks/stack1/None",
  "stackname": "stack1"
}

This is blocking when you want to use the stack id in the instance metadata (eg configuration files of Heat CFN tools).

[Steven Hardy (shardy)]

Ouch.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/58301

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/58301
Committed: http://github.com/openstack/heat/commit/c4f0be36648d94bec439761399fbaeedab4e131e
Submitter: Jenkins
Branch: master

commit c4f0be36648d94bec439761399fbaeedab4e131e
Author: Alexander Chudnovets <email address hidden>
Date: Mon Nov 25 16:42:51 2013 +0200

    Fix not correct AWS::StackId value

    Add call of method _set_param_stackid() to method update_task() in class
    parser.Stack. This ensures that an updated stack still has the right
    AWS::StackId param.
    Add a unit test for this case.

    Change-Id: I0d28346631546577a85735292a24c2512476d4b4
    Closes-Bug: #1240888

[Simon Pasquier (simon-pasquier)]

Why is it marked as Public Security bug?

[Alexander Chudnovets (achudnovets)]

Sorry, just wrong click when accessed from android :)