Nicira plugin: 500 when removing a router port desynchronized from the backend

[Salvatore Orlando]

If the logical switch port backing a neutron router interface port (device_owner=network:router_interface) is removed, then the port goes into ERROR state. However the interface remove process still tries to retrieve that port from the NVP backend, causing a 500 error.

Different tracebacks can be generated according to the conditions which led to the switch port (or the peer router port) to be removed from the backend.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/52232

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/52232
Committed: http://github.com/openstack/neutron/commit/477dac0373b5e84c71365d7a71b9cc41aafcb491
Submitter: Jenkins
Branch: master

commit 477dac0373b5e84c71365d7a71b9cc41aafcb491
Author: Salvatore Orlando <email address hidden>
Date: Wed Oct 16 15:11:34 2013 -0700

    nvp:log only in rm router iface if port not found

    The code currently raises when it's not able to find the port to be
    deleted on the backend. This might happen, for instance, when the
    port is manually removed or, in some cases, if port creation failed
    in the first place.

    There's little sense in raising when a resource to be removed is not
    found; therefore this patch replaces the raise statement with a log
    statement.

    Bug 1240720

    Change-Id: Ifa756b07ef41346a44325341c8e0e8994dc64dde

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/53018

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/53018
Committed: http://github.com/openstack/neutron/commit/c89b20624d39a4be79d29e0d94bb83589ef31ccd
Submitter: Jenkins
Branch: stable/havana

commit c89b20624d39a4be79d29e0d94bb83589ef31ccd
Author: Salvatore Orlando <email address hidden>
Date: Wed Oct 16 15:11:34 2013 -0700

    nvp:log only in rm router iface if port not found

    The code currently raises when it's not able to find the port to be
    deleted on the backend. This might happen, for instance, when the
    port is manually removed or, in some cases, if port creation failed
    in the first place.

    There's little sense in raising when a resource to be removed is not
    found; therefore this patch replaces the raise statement with a log
    statement.

    Bug 1240720

    Change-Id: Ifa756b07ef41346a44325341c8e0e8994dc64dde
    (cherry picked from commit 477dac0373b5e84c71365d7a71b9cc41aafcb491)