[calendar] There is no way to delete an event

[David Planella]

Right now we are able to edit events, but there is no option to delete them.

After a talk with design. Desired solution:

- Add a "Delete" toolbar action in the edit event view, which deletes the event being edited.

[Kunal Parmar (pkunal-parmar)]

Do we have icon for delete?

[David Planella (dpm)]

Yep, there is a delete icon indeed:

$ dpkg -L ubuntu-mobile-icons | grep delete
/usr/share/icons/ubuntu-mobile/actions/scalable/delete.svg

Here's a tip to see the available icons:
https://plus.google.com/115054251212417394181/posts/144iojDbjv5

[Kunal Parmar (pkunal-parmar)]

Edit event is called from EventDetails view.

If we delete event from EditEvent, what we should display in EventDetails.

I think its better to put delete button in EventDetails view same as Edit button.

[Kunal Parmar (pkunal-parmar)]

If seems there are few issue with EDS implementation.

removeItem with itemId is not implementend.
 eventModel.removeItem(event.itemId);

<pkunal-parmar> virtual QtOrganizer::QOrganizerItemEngineId* QOrganizerEDSFactory::createItemEngineId(const QMap<QString, QString>&, const QString&) const
<pkunal-parmar> virtual bool QOrganizerEDSEngine::startRequest(QtOrganizer::QOrganizerAbstractRequest*)
<pkunal-parmar> No implemented request 7
<pkunal-parmar> virtual void QOrganizerEDSEngine::requestDestroyed(QtOrganizer::QOrganizerAbstractRequest*)

Q_INVOKABLE void removeItem(QDeclarativeOrganizerItem *item);

Works, but it shows some error at end and does not emit modelChanged or itemCountChanged signal.

<pkunal-parmar> virtual bool QOrganizerEDSEngine::startRequest(QtOrganizer::QOrganizerAbstractRequest*)
<pkunal-parmar> void QOrganizerEDSEngine::removeItemsAsync(QtOrganizer::QOrganizerItemRemoveRequest*)
<pkunal-parmar> static void QOrganizerEDSEngine::removeItemsAsyncStart(RemoveRequestData*)
<pkunal-parmar> Remove item size: 1
<pkunal-parmar> static void QOrganizerEDSEngine::removeItemsAsyncStart(RemoveRequestData*)
<pkunal-parmar> Item source is null

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Ingmar (ingmars-mailbox-uone)]

Please fix this. You can't use a calendar-app without editing/deleting events at all.

[PS Jenkins bot (ps-jenkins)]

Fix committed into lp:qtorganizer5-eds at revision 25, scheduled for release in qtorganizer5-eds, milestone Unknown

[Launchpad Janitor (janitor)]

This bug was fixed in the package qtorganizer5-eds - 0.1.1+14.04.20140108.2-0ubuntu1

---------------
qtorganizer5-eds (0.1.1+14.04.20140108.2-0ubuntu1) trusty; urgency=low

  [ Renato Araujo Oliveira Filho ]
  * Configured eds to run a new session for each test.
  * Implemented support for query items by id. (LP: #1240808)
  * Implemented support for save multiple items. This new implementation
    allows to save several items in the same call. The items can be part
    of the same collection or not.
  * fixed query items with recurrence.
  * Implemented remove item by id;. (LP: #1240505)
  * Fixed create items without collection id. (LP: #1262296)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 26
 -- Ubuntu daily release <email address hidden> Wed, 08 Jan 2014 02:58:12 +0000

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

Fix committed into lp:ubuntu-calendar-app at revision None, scheduled for release in ubuntu-calendar-app, milestone alpha-1

[Ingmar (ingmars-mailbox-uone)]

I'm on r303 from 2014-04-24 and I cannot delete an all day event (also all day events seem to appear one day in advance from 2:00 to 2:00).