Folder name disappears after clicking on it in a page

[Kristina Hoeppner]

1.8.0rc2

Folder names get lost when you click on them on a page to see them as artefact.

For testing:

Scenario 1:
1. Create a folder in Content -> Files.
2. Add some files to the folder.
3. Create a page.
4. Add the block "Folder" to the page and select the folder.
5. Do not change the block title so that the default title is used.
6. Display the page and click on the block heading.
7. You will not see the folder title displayed. When you go back to the page, your heading is suddenly gone. And when you go back to the Files area, your folder doesn't have a title anymore.

Scenario 2:
1. Create a folder in Content -> Files.
2. Add some files to the folder.
3. Create a page.
4. Add the block "Folder" to the page and select the folder.
5. Change the block title to something else.
6. Display the page and click on the block heading.
7. The folder title is now the block heading and the folder itself changed its name to the block title. That should not happen. The block title is only a temporary renaming for the sake of the block, but should not change what you call the folder in your files area.

[Robert Lyon (robertl-9)]

https://reviews.mahara.org/#/c/2615/
have submitted a patch for this

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/2615
Committed: http://gitorious.org/mahara/mahara/commit/f22dbff50e2f737df30fcb4bd4422566d092b971
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit f22dbff50e2f737df30fcb4bd4422566d092b971
Author: Robert Lyon <email address hidden>
Date: Thu Oct 17 08:10:08 2013 +1300

Artefact title been rewritten by blocktitle (Bug 1240411)

Turns out if one sets the $artefact->title to display the block title
it gets saved at some point :(
- also bad if there is no block title :( :(

So have altered the code to display $currenttitle as a separate
variable intependent from $artefact object

Change-Id: Ia859c5589764565f3aeb11a11c1c73a0ea154a7e
Signed-off-by: Robert Lyon <email address hidden>