view/block.php message is misleading

[Robert Lyon]

When you go to edit a page you see the message:

Select a block and choose where to add it to your page. You can position a block using the arrow buttons in its titlebar.

This occurs if you have the 'Show controls to add and remove columns when editing a page' on or off but there are no arrow buttons in the block's title bar.

Only add/remove column buttons if 'Show controls to add and remove columns when editing a page' is set

I see in the blocktype/lib.php file under render_editing() there is
                if ($this->get('canmoveleft')) {
                    $movecontrols[] = array()
etc

So it looks like it is not working for some reason

[Robert Lyon (robertl-9)]

This is a regression

and here is a fix
https://reviews.mahara.org/#/c/2611/

It adds back some missing js but in the new jquery way

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/2611
Committed: http://gitorious.org/mahara/mahara/commit/6de6468dbb3dc3d9c9e4f08bd4bd26a83e4bccc1
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 6de6468dbb3dc3d9c9e4f08bd4bd26a83e4bccc1
Author: Robert Lyon <email address hidden>
Date: Tue Oct 15 13:44:06 2013 +1300

view/blocks.php showing wrong message when js enabled (bug 1239881)

the ajax off message was being displayed when js enabled causing
confusion about arrows message

Change-Id: I5f7606cbd73019f8229ab303e4ebeeb2f405bb26
Signed-off-by: Robert Lyon <email address hidden>