call_plugin_serialized_with_retry sleeps after final retry

Bug #1239707 reported by John Garbutt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
John Garbutt

Bug Description

The retry logic in call_plugin_serialized_with_retry sleeps even after the final retry.

Also, the sleeps are not stubbed out in the unit test, so it causes the unit tests to run for longer than we need to.

Tags: xenserver
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/51608

Changed in nova:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/51608
Committed: http://github.com/openstack/nova/commit/a8062f900445f9909a1425f0232e6b4176116925
Submitter: Jenkins
Branch: master

commit a8062f900445f9909a1425f0232e6b4176116925
Author: John Garbutt <email address hidden>
Date: Mon Oct 14 14:54:44 2013 +0100

    xenapi: removes sleep after final upload retry

    This change removes the sleep that happens after the final retry of
    uploading an image.

    This change also ensures the unit tests do not take too long by stubbing
    out time.sleep.

    Closes bug 1239707
    Change-Id: I16b6639e3231d41fa476218f406fa5b3abdfaf71

Changed in nova:
status: In Progress → Fix Committed
Changed in nova:
milestone: none → icehouse-1
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.