Mediascanner should only try to resolve albumart when scanning music

Bug #1236880 reported by Thomas Strehl
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
mediascanner
Fix Released
Medium
Jussi Pakkanen
mediascanner (Ubuntu)
Fix Released
Undecided
Unassigned
Saucy
Won't Fix
Undecided
Unassigned

Bug Description

Only when scanning ~/Music albumart should be requested but not in the Documents or Pictures folder. Same applies to tmdb requests.

Related branches

Thomas Strehl (strehl-t)
Changed in mediascanner:
assignee: nobody → Jussi Pakkanen (jpakkane)
Revision history for this message
Pat McGowan (pat-mcgowan) wrote :

Log with debug shows albumart and tmdb tasks on pictures

mediascanner-service[3839]: DEBUG debug/fs-walker: Scanning "/home/phablet/Pictures/IMG_0724.JPG"
mediascanner-service[3839]: DEBUG debug/fs-walker: Found file:///home/phablet/Pictures/IMG_0724.JPG: type
=image/jpeg, etag=1380915527:436207, gstinfo=
mediascanner-service[3839]: DEBUG debug/metadata: Scheduling metadata resolution for file:///home/phablet/P
ictures/IMG_0724.JPG
mediascanner-service[3839]: DEBUG debug/metadata: Pushing resolver task 301@grl-tmdb for media ids of <file
:///home/phablet/Pictures/IMG_0724.JPG>
mediascanner-service[3839]: DEBUG debug/metadata: Pushing resolver task 302@grl-tmdb for details of <file:/
//home/phablet/Pictures/IMG_0724.JPG>
mediascanner-service[3839]: DEBUG debug/metadata: Metadata resolving task 302@grl-tmdb finished
mediascanner-service[3839]: DEBUG debug/metadata: Pushing resolver task 303@grl-lastfm-albumart for details
 of <file:///home/phablet/Pictures/IMG_0724.JPG>
mediascanner-service[3839]: DEBUG debug/metadata: Metadata resolving task 303@grl-lastfm-albumart finished
mediascanner-service[3839]: DEBUG debug/metadata: Filling in metadata from media

Revision history for this message
James Henstridge (jamesh) wrote :

With the new album art code, art is only looked up if the "artist" and "album" metadata keys are available for a file, so that part of the problem should already be solved. If we actually find music with that metadata set outside of ~/Music, I don't think it is a problem to look up the

As far as the TMDB plugin goes, it returns early for non-video files so shouldn't result in extra network traffic. As we never got round to getting the API key though, it is probably best to disable that plugin completely.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mediascanner at revision 396, scheduled for release in mediascanner, milestone Unknown

Changed in mediascanner:
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package mediascanner - 0.3.93+14.04.20131024.1-0ubuntu1

---------------
mediascanner (0.3.93+14.04.20131024.1-0ubuntu1) trusty; urgency=low

  [ Michal Hruby ]
  * A couple of fixes. (LP: #1237484)

  [ James Henstridge ]
  * Create the GNetworkMonitor object earlier to avoid thread safety
    problems in its constructor, fixing bug #1237484. (LP: #1237484)
  * Don't error out if no TheMovieDB API key is provided. Instead
    disable the grl-tmdb metadata resolver. (LP: #1215880, #1236880)
  * Use the ignored-parameters feature in the mock data configuration to
    avoid failures due to some URL encoding differences. (LP: #1243536)

  [ Jussi Pakkanen ]
  * A couple of fixes. (LP: #1237484)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 397
 -- Ubuntu daily release <email address hidden> Thu, 24 Oct 2013 13:28:29 +0000

Changed in mediascanner (Ubuntu):
status: New → Fix Released
Revision history for this message
Rolf Leggewie (r0lf) wrote :

saucy has seen the end of its life and is no longer receiving any updates. Marking the saucy task for this ticket as "Won't Fix".

Changed in mediascanner (Ubuntu Saucy):
status: New → Won't Fix
Changed in mediascanner:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.