[mir] Need an input trap in shell behind the OSK

Bug #1236773 reported by Michał Sawicz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
unity-mir
Fix Released
Critical
Daniel d'Andrada
unity-mir (Ubuntu)
Fix Released
Undecided
Unassigned
unity8 (Ubuntu)
Fix Released
Critical
Daniel d'Andrada

Bug Description

After shell becomes an input monitor (lp:~ricmm/unity-mir/shell-surface-monitor), we now get input behind the OSK. We need to catch it before it reaches the dash.

We can use the OSKController from unity-mir to start with.

Related branches

Michał Sawicz (saviq)
Changed in unity8:
milestone: none → phone-v1-freeze
Changed in unity-mir:
milestone: none → phone-v1-freeze
assignee: nobody → Daniel d'Andrada (dandrader)
importance: Undecided → Critical
status: New → In Progress
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:unity-mir at revision 105, scheduled for release in unity-mir, milestone phone-v1-freeze

Changed in unity-mir:
status: In Progress → Fix Committed
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:unity8 at revision None, scheduled for release in unity8, milestone ubuntu-13.09

Changed in unity8:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity8 - 7.82+13.10.20131008.1-0ubuntu1

---------------
unity8 (7.82+13.10.20131008.1-0ubuntu1) saucy; urgency=low

  [ Michal Hruby ]
  * Add Scope::isActive property and corresponding tests. (LP: #1230352)

  [ Daniel d'Andrada ]
  * Move OSKController to the front as it will now also block input
    meant to the OSK That's in the unity-mir implementation. The
    SurfaceFlinger one is still an empty noop. Currently, when the OSK
    is up, both shell and OSK get user input, thus we need the
    OSKController to shield our shell components from them. (LP:
    #1236773)

  [ Michał Sawicz ]
  * Add Scope::isActive property and corresponding tests. (LP: #1230352)
  * Force focus back on shell in case it loses it for some reason.

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 409
 -- Ubuntu daily release <email address hidden> Tue, 08 Oct 2013 19:14:20 +0000

Changed in unity8 (Ubuntu):
status: New → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity-mir - 0.1+13.10.20131008.2-0ubuntu1

---------------
unity-mir (0.1+13.10.20131008.2-0ubuntu1) saucy; urgency=low

  [ Ricardo Mendoza ]
  * Add support for upstart-app-launch to request application resume &
    focus. This revealed extra work: prevent unexpected focus events
    propagating to shell, fix lifecycle bug and add workaround for
    handling of non-application sessions (like QtWebProcess and maliit).
    (LP: #1228345)
  * Make shell surface be an input monitor. (LP: #1236736, #1231713,
    #1233245)
  * Make sure we dont lose focus on the currently focused application
    when dismissing an invalid session startup. (LP: #1236789)

  [ Daniel d'Andrada ]
  * Do not let touches meant for the OSK hit the Shell components behind
    it. (LP: #1236773)

  [ Michał Sawicz ]
  * Map rect to scene in setMirInputArea and set the geometry onEnabled.
    (LP: #1235383, #1235215)
  * Focus the shell when no sessions are focused. It's difficult with
    the current architecture for the shell to receive keyboard focus, as
    it does not have an associated application session. Work around this
    by implementing a defaulting FocusSetter, which assigns keyboard
    focus to the shell surface when focus would otherwise be cleared.

  [ Robert Carr ]
  * Focus the shell when no sessions are focused. It's difficult with
    the current architecture for the shell to receive keyboard focus, as
    it does not have an associated application session. Work around this
    by implementing a defaulting FocusSetter, which assigns keyboard
    focus to the shell surface when focus would otherwise be cleared.

  [ Gerry Boland ]
  * Add support for upstart-app-launch to request application resume &
    focus. This revealed extra work: prevent unexpected focus events
    propagating to shell, fix lifecycle bug and add workaround for
    handling of non-application sessions (like QtWebProcess and maliit).
    (LP: #1228345)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 105
 -- Ubuntu daily release <email address hidden> Tue, 08 Oct 2013 19:14:08 +0000

Changed in unity-mir (Ubuntu):
status: New → Fix Released
Michał Sawicz (saviq)
Changed in unity-mir:
status: Fix Committed → Fix Released
Changed in unity8:
status: Fix Committed → Fix Released
tags: added: needs-ap-test
Michał Sawicz (saviq)
Changed in unity8 (Ubuntu):
assignee: nobody → Daniel d'Andrada (dandrader)
importance: Undecided → Critical
no longer affects: unity8
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.