Bazaar

"bzr info" depends on private Repository._revision_store

Bug #123653 reported by Jelmer Vernooij
2
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
Low
Unassigned

Bug Description

"bzr info" relies on the private _revision_store member to be available.

  File "/usr/lib/python2.5/site-packages/bzrlib/repository.py", line 321, in gather_stats
    c, t = self._revision_store.total_size(self.get_transaction())
AttributeError: 'NoneType' object has no attribute 'total_size'

Related branches

lp:~jelmer/bzr/repo-size
Rejected for merging into lp:bzr
Robert Collins (community): Needs Fixing
Diff: 136 lines (+55/-1)
7 files modified
NEWS (+3/-0)
bzrlib/remote.py (+10/-0)
bzrlib/repository.py (+6/-1)
bzrlib/smart/repository.py (+13/-0)
bzrlib/smart/request.py (+3/-0)
bzrlib/tests/per_repository/test_statistics.py (+10/-0)
bzrlib/tests/test_smart.py (+10/-0)
Revision history for this message
Martin Pool (mbp) wrote :

It should probably just ask the repository for its size, and do this only if a --verbose or --size option is given.

Changed in bzr:
importance: Undecided → Low
status: New → Confirmed
Jelmer Vernooij (jelmer)
Changed in bzr:
status: Confirmed → Fix Committed
Revision history for this message
Martin Pool (mbp) wrote :

Some problems were raised in review https://code.edge.launchpad.net/~jelmer/bzr/repo-size/+merge/16582

Changed in bzr:
status: Fix Committed → In Progress
Revision history for this message
John A Meinel (jameinel) wrote :

Just poking Jelmer on this one. Since he had a patch for it, and this was considered "In Progress". If you're not actually working on it, that's fine. We can close the bug, or move it back to "patch-needsfixing"

Changed in bzr:
assignee: nobody → Jelmer Vernooij (jelmer)
tags: added: patch-needswork
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

This has already been resolved in another way - Foreign branches simply override Repository.get_stats(), and Repository.revisions is public rather than private.

Changed in bzr:
assignee: Jelmer Vernooij (jelmer) → nobody
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.