config_helper.py:set_general_configs should be removed
Bug #1235689 reported by
Dmitry Mescheryakov
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Sahara |
Fix Released
|
Critical
|
Nikolay Makhotkin | ||
Bug Description
Exact location:
savanna/
method set_general_
It is a very bad idea to change constant GENERAL_CONFS. Besides right now it is not thread-safe as it sets constant based on request-scoped variables hive_hostname and passwd_mysql
We should remove the method completely and do not change constants for each request
| tags: | added: 0.3 |
| Changed in savanna: | |
| milestone: | none → 0.3 |
| importance: | Undecided → Critical |
| status: | New → Triaged |
| Changed in savanna: | |
| assignee: | nobody → Nikolay Makhotkin (nmakhotkin) |
| status: | Triaged → In Progress |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix proposed to savanna (master) | #1 |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix merged to savanna (master) | #2 |
| Changed in savanna: | |
| status: | In Progress → Fix Committed |
| Changed in savanna: | |
| milestone: | 0.3 → 0.3-rc2 |
| Changed in savanna: | |
| status: | Fix Committed → Fix Released |
| Changed in savanna: | |
| milestone: | 0.3-rc2 → 0.3 |
To post a comment you must log in.
Fix proposed to branch: master
Review: https:/