test_cell_update_without_type_specified test fails sporadically

[Dan Smith]

The test_cell_update_without_type_specified test fails sporadically:

======================================================================
2013-10-04 18:17:30.357 | FAIL: nova.tests.api.openstack.compute.contrib.test_cells.CellsTest.test_cell_update_without_type_specified
2013-10-04 18:17:30.358 | tags: worker-3
2013-10-04 18:17:30.358 | ----------------------------------------------------------------------
2013-10-04 18:17:30.358 | Empty attachments:
2013-10-04 18:17:30.359 | pythonlogging:''
2013-10-04 18:17:30.359 | stderr
2013-10-04 18:17:30.359 | stdout
2013-10-04 18:17:30.360 |
2013-10-04 18:17:30.360 | Traceback (most recent call last):
2013-10-04 18:17:30.360 | File "nova/tests/api/openstack/compute/contrib/test_cells.py", line 290, in test_cell_update_without_type_specified
2013-10-04 18:17:30.360 | self.assertEqual(cell['type'], 'parent')
2013-10-04 18:17:30.361 | File "/home/jenkins/workspace/gate-nova-python26/.tox/py26/lib/python2.6/site-packages/testtools/testcase.py", line 322, in assertEqual
2013-10-04 18:17:30.361 | self.assertThat(observed, matcher, message)
2013-10-04 18:17:30.361 | File "/home/jenkins/workspace/gate-nova-python26/.tox/py26/lib/python2.6/site-packages/testtools/testcase.py", line 417, in assertThat
2013-10-04 18:17:30.362 | raise MismatchError(matchee, matcher, mismatch, verbose)
2013-10-04 18:17:30.362 | MismatchError: 'child' != 'parent'
2013-10-04 18:17:30.362 | ======================================================================

More info:

https://jenkins02.openstack.org/job/gate-nova-python26/6256/console

http://logstash.openstack.org/#eyJzZWFyY2giOiJAbWVzc2FnZTpcIk1pc21hdGNoRXJyb3I6ICdjaGlsZCcgIT0gJ3BhcmVudCdcIiIsImZpZWxkcyI6W10sIm9mZnNldCI6MCwidGltZWZyYW1lIjoiOTAwIiwiZ3JhcGhtb2RlIjoiY291bnQiLCJ0aW1lIjp7InVzZXJfaW50ZXJ2YWwiOjB9LCJzdGFtcCI6MTM4MDkxMTY5ODYzMH0=

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/49804
Committed: http://github.com/openstack/nova/commit/bb2c3c58258d6746cf2b3c28f4533b406e3fdc6f
Submitter: Jenkins
Branch: master

commit bb2c3c58258d6746cf2b3c28f4533b406e3fdc6f
Author: Chris Behrens <email address hidden>
Date: Fri Oct 4 18:49:00 2013 +0000

    Fix races in cells extension tests

    A global was used for a cell list and tests would update this global and
    fail depending on order run, etc.

    Fixes bug 1235399

    Change-Id: Ib06cfc89076e87ac3cfedd796687059862f20406

[Mark McLoughlin (markmc)]

Applies to the v3 tests too

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/49876

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/49876
Committed: http://github.com/openstack/nova/commit/c17253bde86f62952351d42db4dba926b33269db
Submitter: Jenkins
Branch: master

commit c17253bde86f62952351d42db4dba926b33269db
Author: Mark McLoughlin <email address hidden>
Date: Sat Oct 5 13:59:44 2013 +0100

    Fix races in v3 cells extension tests

    A global was used for a cell list and tests would update this global
    and fail depending on order run, etc.

    Yes, this is the same fix as commit bb2c3c5 except for the v3
    extension. Yes, copied and pasted code is utterly evil. No, we
    apparently will never learn.

    Closes-Bug: #1235399
    Change-Id: I3406d0440aed38cbf3a9bedf24420fb867876b08