minor memory leak when updating menu icon

Bug #1234895 reported by Charles Kerr
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Messaging Menu
Fix Released
Medium
Charles Kerr
indicator-messages (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Found while doing code inspection for bug #1234673.

in im_application_list_update_draws_attention(), the variable 'icon_name' is created by g_strdup_printf, passed to g_themed_icon_new_with_default_fallbacks(), and then never referred to again. It should be freed after icon_new().

Related branches

Charles Kerr (charlesk)
Changed in indicator-messages:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Charles Kerr (charlesk)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:indicator-messages at revision None, scheduled for release in indicator-messages, milestone 13.10.0

Changed in indicator-messages:
status: In Progress → Fix Committed
Revision history for this message
Charles Kerr (charlesk) wrote :

Released in 13.10.1+13.10.20131004-0ubuntu1

Changed in indicator-messages:
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package indicator-messages - 13.10.1+13.10.20131004-0ubuntu1

---------------
indicator-messages (13.10.1+13.10.20131004-0ubuntu1) saucy; urgency=low

  [ Charles Kerr ]
  * in im_application_list_update_draws_attention(), free the temporary
    icon_name string created by g_strdup_printf(). (LP: #1234895)

  [ Sebastien Bacher ]
  * remove old sources from the translatable list.

  [ Lars Uebernickel ]
  * messages-service: return TRUE from "handle-*" GDBusProxy method
    handlers This is done to signify that the handlers replied to the
    messages. Otherwise GDBus might send another reply, depending on
    whether 0 or !0 was lying around on the stack. .
  * Change title to "Incoming".
  * Remove 'indicator.' from the "Clear All" menu item on the phone's
    menu.
  * Return values from functions that have return values. Somehow -
    Wreturn-type warnings aren't always triggered for g_return_if_fail
    macros.

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 388
 -- Ubuntu daily release <email address hidden> Fri, 04 Oct 2013 02:28:41 +0000

Changed in indicator-messages (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.