GVariant assertion errors

[Paweł Stołowski]

Under some circumstances the scope produces a lot of gvariant criticals:

(process:1722): GLib-CRITICAL **: g_variant_new_string: assertion 'string != NULL' failed
(process:1722): GLib-CRITICAL **: g_variant_new_variant: assertion 'value != NULL' failed
(process:1722): GLib-CRITICAL **: g_variant_get_type: assertion 'value != NULL' failed
(process:1722): GLib-CRITICAL **: g_variant_type_is_subtype_of: assertion 'g_variant_type_check (type)' failed
(process:1722): GLib-CRITICAL **: g_variant_builder_add_value: assertion '!GVSB(builder)->expected_type || g_variant_is_of_type ...
...

See attachement for full log.

[Michal Hruby (mhr3)]

Identified the culprit as unity-scope-click, not unity-scope-onlinemusic.

[Ying-Chun Liu (paulliu)]

Hi,

I've tried the scope but however cannot find a productive way to reproduce this bug.

I'm wondering if Line 157 in http://bazaar.launchpad.net/~ubuntuone-hackers/unity-scope-click/trunk/view/head:/src/click-scope.vala
causes the bug. As it tries to put a string as a variant.

[Ying-Chun Liu (paulliu)]

hmm, ignore #3. Should not be that problem as vala does the convertion.

[Mike McCracken (mikemc)]

Paul, I noticed these messages while testing something else, and was able to reproduce reliably by killing both unity8 and the click scope, then starting up the click scope:

pkill unity8; pkill click; G_MESSAGES_DEBUG=all ./src/click-scope

- it will print the assertions just after unity restarts.

This agrees with what I was seeing while trying to reproduce it manually - it seemed to print the assertions the first time I opened the apps scope after restarting the phone.

Hope this is useful...

[Ying-Chun Liu (paulliu)]

Seems I cannot reproduce that on my desktop. I'll try to reproduce that on my phone.

I attached the log I've tried on desktop. There's no critical ones. I tried that many times and tried many ways. but the logs seems to be similar. Just works fine.

[PS Jenkins bot (ps-jenkins)]

Fix committed into lp:unity-scope-click at revision 79, scheduled for release in unity-scope-click, milestone Unknown

[Launchpad Janitor (janitor)]

This bug was fixed in the package unity-scope-click - 0.1+14.04.20140113-0ubuntu1

---------------
unity-scope-click (0.1+14.04.20140113-0ubuntu1) trusty; urgency=low

  [ Michal Hruby ]
  * Update definition of non-click apps, so we don't waste time trying
    to find them. (LP: #1239745)

  [ Ying-Chun Liu ]
  * Fix GVariant critical errors. (LP: 1234833). (LP: #1234833)

  [ Leo Arias ]
  * Added a simple autopilot test that opens the scope.

  [ Alejandro J. Cura ]
  * Reinstate get_dotdesktop test.
  * When opening a preview, check if there's a download in progress.
  * Handle invalidated tokens by removing UOA account. (LP: #1248326).
    (LP: #1248326)

  [ Michael McCracken ]
  * Generate app preview for purchasing in response to a buy action.
    Handle purchase succeeded/failed.
  * When opening a preview, check if there's a download in progress.
  * Handle invalidated tokens by removing UOA account. (LP: #1248326).
    (LP: #1248326)
  * Send correct application:/// url to preview after install (LP:
    #1262780). (LP: #1262780)
  * Check for download progress when building default preview (LP:
    #1263807). (LP: #1263807)

  [ Rodney Dawes ]
  * Add a CLICK_PACKAGE_ARCH env var to override the architecture for
    testing. (LP: #1237514)
  * Use a "Buy" button for uninstalled apps with non-zero prices. (LP:
    #1257292)
  * Get rid of tests that depend too heavily on external processes or
    data. (LP: #1257474)
  * Run the tests during make check. Rename click-scope-tests to more
    standard test-scope-click. Move click-scope-tests to a noinst
    program to avoid installation to system. . (LP: #1257475, #1257478,
    #1257479)
  * Bring back the get_credentials test, using a fake class to avoid
    dbus.
  * Refactor preview building to pass the ScopeResult, rather than only
    some values. (LP: #1258239)
  * Refactor the price to not be converted to a string until necessary.
    Show the price in the Buy button. (LP: #1258519)
  * Don't reimplement generated rules for vala. Take advantage of
    VALA_CHECK_MODULES to find vala packages. Split non-compatible
    mdoules to another PKG_CHECK_MODULES. Build majority of the code as
    a noinst lib, which click-scope and tests link to. Update the
    .bzrignore for an autools project. . (LP: #1258559)
  * Fix test_get_dotdesktop to use fake data, and remove the fake
    script. Move the contents of gcov.m4 to acinclude.m4 and remove the
    m4 directory. (LP: #1258177, #1257466)
  * Add autopkgtest configuration to the package. Remove the build-
    depends on libsecret-dev as we don't use it any longer. Simplify the
    vcs-bzr URL to just be the lp:unity-scope-click alias. (LP:
    #1261852)
  * Use $PROTOCOLPRIVATELIBDIR as $libdir may not be set to same path
    during build. (LP: #1262327)
  * Remove test_available_apps to avoid network access, and as the rest
    of the search() code is already tested in other tests. (LP:
    #1262364)
  * Replace the webservice object on the scope to avoid network access.
    (LP: #1262821)
  * Add dependency on ubuntu-purchase-service. Update the control file
    with wrap-and-sort -a -t.

  [ Ubuntu daily release ]
  * Automatic snaps...

[Rolf Leggewie (r0lf)]

saucy has seen the end of its life and is no longer receiving any updates. Marking the saucy task for this ticket as "Won't Fix".