v2 member-create call allows the same tenant to be added multiple times

[Brian Rosmaita]

This is glanceclient output, but it's happening at the api level.

demo! glance --os-image-api-version 2 member-list --image-id a96be11e-8536-4910-92cb-de50aa19dfe6
+--------------------------------------+----------------------------------+----------+
| Image ID | Member ID | Status |
+--------------------------------------+----------------------------------+----------+
| a96be11e-8536-4910-92cb-de50aa19dfe6 | | pending |
| a96be11e-8536-4910-92cb-de50aa19dfe6 | 8989447062e04a818baf9e073fd04fa7 | rejected |
| a96be11e-8536-4910-92cb-de50aa19dfe6 | 8989447062e04a818baf9e073fd04fa7 | pending |
| a96be11e-8536-4910-92cb-de50aa19dfe6 | 8989447062e04a818baf9e073fd04fa7 | pending |
+--------------------------------------+----------------------------------+----------+

demo! glance --os-image-api-version 2 member-delete a96be11e-8536-4910-92cb-de50aa19dfe6 8989447062e04a818baf9e073fd04fa7

demo! glance --os-image-api-version 2 member-list --image-id a96be11e-8536-4910-92cb-de50aa19dfe6+--------------------------------------+----------------------------------+---------+
| Image ID | Member ID | Status |
+--------------------------------------+----------------------------------+---------+
| a96be11e-8536-4910-92cb-de50aa19dfe6 | | pending |
| a96be11e-8536-4910-92cb-de50aa19dfe6 | 8989447062e04a818baf9e073fd04fa7 | pending |
| a96be11e-8536-4910-92cb-de50aa19dfe6 | 8989447062e04a818baf9e073fd04fa7 | pending |
+--------------------------------------+----------------------------------+---------+

So the workaround is to delete them all. As far as I can tell, when the member does an image-list, the visibility is controlled by the status of the first occurrence of the tenantId. Same thing when the member updates his/her status.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/48496

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/48496
Committed: http://github.com/openstack/glance/commit/2d1a67a9f6a032045c8176a1a53d7613d8b0d567
Submitter: Jenkins
Branch: master

commit 2d1a67a9f6a032045c8176a1a53d7613d8b0d567
Author: Fei Long Wang <email address hidden>
Date: Fri Sep 27 01:05:29 2013 +0800

    Do not allow the same member to be added twice

    This patch add an existence check before add new member for image.

    Fixes bug 1231485

    Change-Id: I10d37c6f169e070ea6699cca78b6360be9fb11dc

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/50829

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/50829
Committed: http://github.com/openstack/glance/commit/f3b178481f11b09172fd2a2ff159b101702ce251
Submitter: Jenkins
Branch: milestone-proposed

commit f3b178481f11b09172fd2a2ff159b101702ce251
Author: Fei Long Wang <email address hidden>
Date: Fri Sep 27 01:05:29 2013 +0800

    Do not allow the same member to be added twice

    This patch add an existence check before add new member for image.

    Fixes bug 1231485

    Change-Id: I10d37c6f169e070ea6699cca78b6360be9fb11dc

[Alex Meade (alex-meade)]

Made a bug with some more thoughts around this issue: https://bugs.launchpad.net/glance/+bug/1255607