[taskflow] Quotas are not rolled back on failure of create volume

Bug #1230176 reported by Rohit Karajgi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
High
John Griffith

Bug Description

Commit: 1874d913ecbf8f09809992c98496365327905211

After the QuotaCommitTask commits the reserved quotas, and a failure occurs at a subsequent Task,
the revert method of the QuotaReserveTask gets called, and completes, however the quotas don't actually get rolled back.

Tags: ntt
Changed in cinder:
assignee: nobody → Abhijeet Malawade (abhijeet-malawade)
Rohit Karajgi (rohitk)
description: updated
Changed in cinder:
importance: Undecided → High
milestone: none → havana-rc1
Vincent Hou (houshengbo)
Changed in cinder:
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/49103

Changed in cinder:
status: Confirmed → In Progress
Changed in cinder:
assignee: Abhijeet Malawade (abhijeet-malawade) → John Griffith (john-griffith)
Revision history for this message
John Griffith (john-griffith) wrote :

Abhijeet,

Assigned back to you, it was your work and your fix. I just didn't have a way to get ahold of you and it needed a rebase so I did a simple rebase and reposted.

Thanks for taking care of this!

John

Changed in cinder:
assignee: John Griffith (john-griffith) → Abhijeet Malawade (abhijeet-malawade)
Changed in cinder:
assignee: Abhijeet Malawade (abhijeet-malawade) → John Griffith (john-griffith)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/49103
Committed: http://github.com/openstack/cinder/commit/d7623249847010edd2b97085506064da0b642d8d
Submitter: Jenkins
Branch: master

commit d7623249847010edd2b97085506064da0b642d8d
Author: Abhijeet Malawade <email address hidden>
Date: Fri Sep 27 05:13:52 2013 -0700

    Quotas roll back failure of create volume task

    Fixes quotas rollback issue if volume creation fails

    * Added revert method in QuotaCommitTask to rollback
    * volume reservations.

    Fixes bug #1230176

    Change-Id: I0983ea876983b4294ed0aebb49a065715a185b4e

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.