false positive on changing folders in file attachments

[Robert Lyon]

The leave page (dirty changes) warning appears on form pages where there is a file attachment selector option in a form (eg journal entries) when trying to go from one file directory to another.

To test:

1) Upload some file in Content -> files to a new subdirectory.

2) Fill in details on a form that has file attachments (eg Journal entry)

3) Click 'Add a file' button and choose to navigate to a subdirectory

Expected result: go to the subdirectory and pick a file

Actual result: get prompted about leaving page

The bug is to do with the dirty changes patch and how file attachments work. When changing directories the form looks to save it's state and re-display itself but the dirty changes is not recognising this and thinking data is being lost when it is not.

[Robert Lyon (robertl-9)]

https://reviews.mahara.org/#/c/2520

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/2520
Committed: http://gitorious.org/mahara/mahara/commit/3fd58808fd0a21836514d4f25047d73d6e283153
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 3fd58808fd0a21836514d4f25047d73d6e283153
Author: Robert Lyon <email address hidden>
Date: Tue Sep 24 11:20:00 2013 +1200

Artefact chooser giving false positive for dirty changes Bug #1228917

To test:
- create a subdirectory in content -> files section
- add some files there
- go back to parent dir and edit a file's metadata but don't save it
- try moving back into subdirectory. It should warn you about changes
this is correct behaviour

Now begin to make a journal entry, pust some text into some fields
- select 'add a file' and go to navigate to subdirectory
- gives you warning but it shouldn't
this is incorrect behaviour

after patch applied the first part should still be have correctly and
the second part should not give the warning when moving between
directories.

Change-Id: Iaf82e3421a1c3ff965110f67f736012df44b9b80
Signed-off-by: Robert Lyon <email address hidden>