Mahara

Missing lang string for existing URL on allowed iframes

Bug #1227372 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Kristina Hoeppner
Mahara 1.8.0
1.6
Fix Released
Medium
Kristina Hoeppner
Mahara 1.6.7
1.7
Fix Released
Medium
Kristina Hoeppner
Mahara 1.7.3

Bug Description

When you add an iframe URL to /admin/extensions/iframesites.php and add the same one again, you get a warning with the missing lang string for [[urlalreadyexists/mahara]].

Tags: lang
Aaron Wells (u-aaronw)
Changed in mahara:
milestone: 1.8rc1 → 1.8.0
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

Oh my. I had this 1.8 patch sitting there for ages. It's now pushed: https://reviews.mahara.org/2547

and can then be cherry-picked for the other branches if all is good.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/2547
Committed: http://gitorious.org/mahara/mahara/commit/dc2ae096665e36e059485fb86216fa758cd05e56
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit dc2ae096665e36e059485fb86216fa758cd05e56
Author: Kristina D.C. Hoeppner <email address hidden>
Date: Thu Sep 19 09:46:10 2013 +1200

Add missing lang string for warning (Bug #1227372)

Lang string was missing for "Allowed iframe sources"

Change-Id: I1cab612134a334fac7f0ca54fcf406b4a08f3226
Signed-off-by: Kristina D.C. Hoeppner <email address hidden>

Aaron Wells (u-aaronw)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

patch for 1.7: https://reviews.mahara.org/2557

patch for 1.6: https://reviews.mahara.org/2558

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/2558
Committed: http://gitorious.org/mahara/mahara/commit/e147f3c9a893c15300e6bedcb77e9e9e2e068f6b
Submitter: Son Nguyen (<email address hidden>)
Branch: 1.6_STABLE

commit e147f3c9a893c15300e6bedcb77e9e9e2e068f6b
Author: Kristina D.C. Hoeppner <email address hidden>
Date: Thu Sep 19 09:46:10 2013 +1200

Add missing lang string for warning (Bug #1227372)

Lang string was missing for "Allowed iframe sources"

Change-Id: I1cab612134a334fac7f0ca54fcf406b4a08f3226
Signed-off-by: Kristina D.C. Hoeppner <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/2557
Committed: http://gitorious.org/mahara/mahara/commit/305bd94dfede1c95d3fcc984bfbbaa4e6097518d
Submitter: Son Nguyen (<email address hidden>)
Branch: 1.7_STABLE

commit 305bd94dfede1c95d3fcc984bfbbaa4e6097518d
Author: Kristina D.C. Hoeppner <email address hidden>
Date: Thu Sep 19 09:46:10 2013 +1200

Add missing lang string for warning (Bug #1227372)

Lang string was missing for "Allowed iframe sources"

Change-Id: I1cab612134a334fac7f0ca54fcf406b4a08f3226
Signed-off-by: Kristina D.C. Hoeppner <email address hidden>

Aaron Wells (u-aaronw)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.