WSME 0.5b5 returns correct response status codes -- breaking unit tests

Bug #1227264 reported by gordon chung
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Critical
Julien Danjou

Bug Description

WSME 0.5b5 was updated to return more accurate response status codes. we need to fix our unit tests to accept them.

should be related to these patches:
https://review.openstack.org/#/c/45476/
https://review.openstack.org/#/c/45466/

gordon chung (chungg)
Changed in ceilometer:
assignee: nobody → gordon chung (chungg)
summary: - WSME 0.5b5 returns correct response status codes
+ WSME 0.5b5 returns correct response status codes -- breaking unit tests
description: updated
Revision history for this message
gordon chung (chungg) wrote :

secondary issue is that when we pass in translatable text to wsme.exc.ClientSideError(), it implodes.

in wsme, https://github.com/stackforge/wsme/blob/master/wsme/exc.py#L15

it checks for type which appears to be unicode but is really <class 'ceilometer.openstack.common.gettextutils.Message'>. when it tries to convert gettexutils.Message to unicode six.u(), it breaks.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/47221

Changed in ceilometer:
status: New → In Progress
Revision history for this message
Terri Yu (terriyu) wrote :
Changed in ceilometer:
assignee: gordon chung (chungg) → Julien Danjou (jdanjou)
Julien Danjou (jdanjou)
Changed in ceilometer:
importance: Undecided → Critical
milestone: none → havana-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/47221
Committed: http://github.com/openstack/ceilometer/commit/3a480cb4244cf53b11c53108f4bc7afd8b1eb253
Submitter: Jenkins
Branch: master

commit 3a480cb4244cf53b11c53108f4bc7afd8b1eb253
Author: Gordon Chung <email address hidden>
Date: Wed Sep 18 14:29:26 2013 -0400

    WSME 0.5b5 breaking unit tests

    - fix tests to accept new (accurate) response codes
    - wsme doesn't like us sending gettextutils.Message values. pass in
    a regular string

    Change-Id: Ie9e05edfd542ba1fe8c6fdbeed2daab12cf30caf
    Fixes:Bug #1227264

Changed in ceilometer:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.