Use QStandardPaths instead of reading the XDG data by it self.
Bug #1226998 reported by
Manuel de la Peña
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| ubuntu-download-manager |
Fix Released
|
Low
|
Manuel de la Peña | ||
| ubuntu-download-manager (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
The code has its own implementation of XDG (because QStandardPaths did no support XDG at the time). We should move to QStandardPaths in Qt5.
Related branches
lp:~mandel/ubuntu-download-manager/use-standard-dirs
- PS Jenkins bot: Approve (continuous-integration)
- Alejandro J. Cura (community): Approve
- Diego Sarmentero (community): Approve
-
Diff: 1257 lines (+138/-657)28 files modifiedlibubuntudownloadmanager/apparmor.cpp (+17/-5)
libubuntudownloadmanager/downloads_db.cpp (+16/-6)
libubuntudownloadmanager/libubuntudownloadmanager.pro (+0/-2)
libubuntudownloadmanager/logger.cpp (+11/-4)
libubuntudownloadmanager/single_download.cpp (+0/-1)
libubuntudownloadmanager/xdg_basedir.cpp (+0/-204)
libubuntudownloadmanager/xdg_basedir.h (+0/-57)
ubuntu-download-manager-tests/base_testcase.cpp (+51/-1)
ubuntu-download-manager-tests/base_testcase.h (+6/-1)
ubuntu-download-manager-tests/test_download.cpp (+5/-41)
ubuntu-download-manager-tests/test_download.h (+1/-5)
ubuntu-download-manager-tests/test_download_daemon.cpp (+3/-1)
ubuntu-download-manager-tests/test_download_daemon.h (+1/-1)
ubuntu-download-manager-tests/test_download_factory.cpp (+3/-1)
ubuntu-download-manager-tests/test_download_factory.h (+1/-1)
ubuntu-download-manager-tests/test_download_manager.cpp (+3/-1)
ubuntu-download-manager-tests/test_download_manager.h (+1/-1)
ubuntu-download-manager-tests/test_download_queue.cpp (+3/-1)
ubuntu-download-manager-tests/test_download_queue.h (+1/-1)
ubuntu-download-manager-tests/test_downloads_db.cpp (+6/-40)
ubuntu-download-manager-tests/test_downloads_db.h (+1/-5)
ubuntu-download-manager-tests/test_group_download.cpp (+3/-1)
ubuntu-download-manager-tests/test_group_download.h (+1/-1)
ubuntu-download-manager-tests/test_network_reply.cpp (+3/-1)
ubuntu-download-manager-tests/test_network_reply.h (+1/-1)
ubuntu-download-manager-tests/test_xdg_basedir.cpp (+0/-203)
ubuntu-download-manager-tests/test_xdg_basedir.h (+0/-68)
ubuntu-download-manager-tests/ubuntu-download-manager-tests.pro (+0/-2)
| summary: |
- USe QStandardPaths instead of reading the XDG data by it self. + Use QStandardPaths instead of reading the XDG data by it self. |
| Changed in ubuntu-download-manager: | |
| status: | Triaged → In Progress |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | #1 |
| Changed in ubuntu-download-manager: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #2 |
| Changed in ubuntu-download-manager (Ubuntu): | |
| status: | New → Fix Released |
| Changed in ubuntu-download-manager: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:ubuntu-download-manager at revision 143, scheduled for release in ubuntu-