Migration 201 isn't tested correctly

[Joshua Hesketh]

In the migration tests instead of checking the new indexes are created against a table the indexes dictionary is overwritten causing the assertIn to only check against itself. EG:

         for table_name, indexes in data.iteritems():
             table = sqlalchemy.Table(table_name, meta, autoload=True)
            indexes = [(i.name, tuple(i.columns.keys()))
                       for i in table.indexes]

             for index in indexes:
                self.assertIn(index, indexes)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/47075

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/47075
Committed: http://github.com/openstack/nova/commit/34ccbc9ba638a1f72786a5317372c152aef948f8
Submitter: Jenkins
Branch: master

commit 34ccbc9ba638a1f72786a5317372c152aef948f8
Author: Joshua Hesketh <email address hidden>
Date: Wed Sep 18 13:38:10 2013 +1000

    Fix migration 201 tests to actually test changes

    Previously for migration 201 the indexes dictionary was overwritten
    causing the assertIn statement to tests against itself. This patch
    fixes it so that the test checks the new indexes are created
    correctly against the table and also checks they are removed on
    downgrade.

    Fixes bug 1226924

    Change-Id: Ie518041c6b7d534ed1b96e2f9b4e7206f4b68d87