Warn about use of deprecated assertion methods

Bug #1226835 reported by Richard Wall
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
twistedchecker
Won't Fix
Undecided
Unassigned

Bug Description

It might be worth adding warnings about the use of deprecated assertion methods while we're waiting for them to be actually deprecated, so people don't accidentally use them.
 * https://twistedmatrix.com/trac/ticket/4991

Once they are all deprecated, this won't be necessary because they will print deprecation warnings which will be picked up by trial.

Revision history for this message
Jean-Paul Calderone (exarkun) wrote :

This is what PendingDeprecationWarning is for. twistedchecker is the wrong tool for this. Suggest close as wontfix.

Revision history for this message
Richard Wall (richardw) wrote :

I agree. Lets close this. I opened the ticket, but don't seem to have permission to close it.

14:47 < rwall> exarkun: In https://bugs.launchpad.net/twistedchecker/+bug/1226835 you mention PendingDeprecationWarning
14:48 < rwall> Shall I create a ticket to add PendingDeprecationWarning to all the affected assertions?
14:50 < rwall> Actually, no that's just going to cause all the same warnings as a standard deprecation
14:50 < rwall> https://twistedmatrix.com/trac/ticket/4990
14:52 < rwall> Sorry https://twistedmatrix.com/trac/ticket/4991
14:53 < exarkun> Ah that's less confusing.
14:54 < exarkun> Do I think that #4991 should be resolved? Sure, that'd be great. :)
14:54 < exarkun> (as long as Twisted itself has stopped using the deprecated APIs)
14:55 < rwall> So your point is, don't waste time adding new checks to twistedchecker, just do the work of replacing and then deprecating the old
               assertions.
14:56 < exarkun> well, I like that point, but I don't think it's the one I was making
14:56 -!- khorn1 [~<email address hidden>] has joined #twisted-dev
14:57 < exarkun> or maybe it was, I dunno
14:57 < exarkun> I don't think twistedchecker is the right tool to use in this case though
14:57 < rwall> Yep, I agree. I'll close the twistedchecker ticket. It's not worth the effort.
14:57 < exarkun> the APIs are going to be deprecated, deprecation warnings are the tool to help us deal with that
14:57 < exarkun> great, thanks

Tom Prince (tom.prince)
Changed in twistedchecker:
status: New → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.