ConfKeyManagerTestCase doesn't verify that keymgr.fixed_key is actually used

Bug #1226228 reported by Mark McLoughlin
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Thang Pham

Bug Description

See bug #1224602

In ConfKeyManagerTestCase we set keymgr.fixed_key but don't actually check that it was used

Tags: testing
Dan Prince (dan-prince)
Changed in nova:
assignee: nobody → Dan Prince (dan-prince)
tags: added: testing
Mathew Odden (locke105)
Changed in nova:
importance: Undecided → High
status: New → In Progress
Dan Prince (dan-prince)
Changed in nova:
assignee: Dan Prince (dan-prince) → nobody
Changed in nova:
status: In Progress → Confirmed
Thang Pham (thang-pham)
Changed in nova:
assignee: nobody → Thang Pham (thang-pham)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/84517

Changed in nova:
status: Confirmed → In Progress
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/84517
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=a95f83abd6871bd62937ac776dc9b4c137dabb4c
Submitter: Jenkins
Branch: master

commit a95f83abd6871bd62937ac776dc9b4c137dabb4c
Author: Thang Pham <email address hidden>
Date: Tue Apr 1 14:26:25 2014 -0400

    Added test cases in ConfKeyManagerTestCase to verify fixed_key.

    ConfKeyManagerTestCase sets the fixed_key option, but does not
    perform checks to verify it was used. This patch adds the
    appropriate unit test cases to verify the fixed_key option.

    Change-Id: I686b095eeb86b67271dc0e3cb5b6acd5a24d3d03
    Closes-Bug: #1226228

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → juno-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.