ConfKeyManager isn't wired into its super class

Bug #1224602 reported by Dan Prince
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Dan Prince

Bug Description

Using the latest Nova Havana codebase. It looks like the keymgr.conf_key_manager code isn't properly wired into its superclass.

It has a method called _get_hex_key which should actually be named _generate_hex_key so that it properly overrides its superclass's method.

As is this class is effectively the same as single_key_mgr.SingleKeyManager.

Dan Prince (dan-prince)
Changed in nova:
assignee: nobody → Dan Prince (dan-prince)
status: New → In Progress
Mark McLoughlin (markmc)
Changed in nova:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/46322
Committed: http://github.com/openstack/nova/commit/2f43ba83b67d8b415698005786d366a8c5cb9107
Submitter: Jenkins
Branch: master

commit 2f43ba83b67d8b415698005786d366a8c5cb9107
Author: Dan Prince <email address hidden>
Date: Thu Sep 12 13:36:45 2013 -0400

    Wire in ConfKeyManager._generate_hex_key!

    Rename _get_hex_key to _generate_hex_key so that this
    key manager works with the super class it extends.

    In making this change we also need to initialize the hex key
    in the constructor before initializing the super class. Not
    doing so causes test failures.

    Fixes bug: 1224602

    Change-Id: I9a6bd9bf96bf74a08e607af811ebbe9622b994f3

Changed in nova:
status: In Progress → Fix Committed
Changed in nova:
milestone: none → havana-rc1
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.