[HDP] certain ambari blueprint inputs need to be filtered during convert

Bug #1226109 reported by Jonathan Maron
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Sahara
Fix Released
Medium
Jonathan Maron

Bug Description

There are some blueprint values that are not intended to be displayed to users. However, _map_to_user_inputs makes use of get_configs to assess whether a given template driven input is valid. So the convert operation needs to be modified to filter out any inputs that are not recognized as user inputs (displayable inputs).

Jonathan Maron (jmaron)
Changed in savanna:
assignee: nobody → Jonathan Maron (jmaron)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to savanna (master)

Fix proposed to branch: master
Review: https://review.openstack.org/46766

Changed in savanna:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to savanna (master)

Reviewed: https://review.openstack.org/46766
Committed: http://github.com/stackforge/savanna/commit/ebf6d4b735ffa603d132a0063c1ef3f28561ca85
Submitter: Jenkins
Branch: master

commit ebf6d4b735ffa603d132a0063c1ef3f28561ca85
Author: Jon Maron <email address hidden>
Date: Mon Sep 16 12:19:56 2013 -0400

    Filter out some vendor based input from a template upload

    Some values in the vendor blueprint (e.g. Ambari blueprint) are not
    intended to be displayed to users. They are now filtered out at
    the convert() call to prevent issues during _map_to_user_inputs
    (it makes use of get_configs() and can raise exceptions is the
    input is not returned).

    Fixes: bug #1226109

    Change-Id: Iae6afa65221f9ef7c5025c9f8d9dbc92f32da7bb

Changed in savanna:
status: In Progress → Fix Committed
Changed in savanna:
importance: Undecided → Medium
milestone: none → 0.2.2
tags: added: 0.2.2 0.3 plugin.hdp
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to savanna (stable/0.2)

Fix proposed to branch: stable/0.2
Review: https://review.openstack.org/46786

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to savanna (stable/0.2)

Reviewed: https://review.openstack.org/46786
Committed: http://github.com/stackforge/savanna/commit/00db2160de0647b107087e1b65c6e6eb37eab87c
Submitter: Jenkins
Branch: stable/0.2

commit 00db2160de0647b107087e1b65c6e6eb37eab87c
Author: Jon Maron <email address hidden>
Date: Mon Sep 16 14:29:50 2013 -0400

    Filter out some vendor based input from a template upload

    Some values in the vendor blueprint (e.g. Ambari blueprint) are not
    intended to be displayed to users. They are now filtered out at
    the convert() call to prevent issues during _map_to_user_inputs
    (it makes use of get_configs() and can raise exceptions is the
    input is not returned).

    Fixes: bug #1226109

    Change-Id: Iae6afa65221f9ef7c5025c9f8d9dbc92f32da7bb
    (cherry picked from commit ebf6d4b735ffa603d132a0063c1ef3f28561ca85)

Changed in savanna:
milestone: 0.2.2 → 0.2.2-rc2
Changed in savanna:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.