nicira plugin: sync process crashed on multi-chunk synchronization

Bug #1224719 reported by Salvatore Orlando
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Salvatore Orlando

Bug Description

During one of the last iterations of the review process, an issue with large page sizes was noticed and addressed.
Unfortunately the solution for this issue introduced another bug because it neglects a peculiar behavior of the NVP api, which does not return the total number of items in the body for paginated responses.

The manifestation of the error is as follows: http://codepad.org/aU03DtUE

This issue eludes unit tests because the fake api client does not handle _page_cursor request parameter.

Tags: nicira
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/46373

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/46373
Committed: http://github.com/openstack/neutron/commit/de1db2023597dd3555da33bd86582627c85d4856
Submitter: Jenkins
Branch: master

commit de1db2023597dd3555da33bd86582627c85d4856
Author: Salvatore Orlando <email address hidden>
Date: Thu Sep 12 15:23:46 2013 -0700

    Fix failure in multi-chunk state sync for nicira plugin

    Bug 1224719

    This patch ensures the 'result_count' attribute from NVP API responses
    is properly handled, and adds support for '_page_cursor' request query
    parameter in the fake nvp api client in order to ensure issues like this
    are captured by unit tests.

    Change-Id: I1d6179bd58a14d19729fc882f004b6d1afccbe3d

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.