xenapi: don't refetch network_info when building config drive

Bug #1224508 reported by John Garbutt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
John Garbutt

Bug Description

There is no need to refetch the network_info when building config_drive, we can just pass through the network_info we already have.

Tags: xenserver
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/46290

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/46290
Committed: http://github.com/openstack/nova/commit/137a1cd9c1df3026f0b7faa10bb10517916f5756
Submitter: Jenkins
Branch: master

commit 137a1cd9c1df3026f0b7faa10bb10517916f5756
Author: John Garbutt <email address hidden>
Date: Fri Sep 6 13:15:32 2013 +0100

    xeanpi: pass network_info to generate_configdrive

    Currently network_info is being fetched when generating config drive.
    This change ensures the network_info that is already available is
    re-used when generating the config_drive.

    In addition, it is more consistent to use the network_info that is
    passed into this function, rather than potentially lazy loading the
    whole info_cache of the instance from the DB, which may not yet be
    populated when we are generating the metadata for ConfigDrive anyway.

    Fixes bug 1224508
    Change-Id: I3e6f5a987593ecd422be61ac50c0d74463ba25d5

Changed in nova:
status: In Progress → Fix Committed
Changed in nova:
milestone: none → icehouse-1
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.