Glance

Property protections not enforced in order

Bug #1224449 reported by Paul Bourke on 2013-09-12

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Glance	Fix Released	High	Thomas Leaman	Glance 2013.2 "havana"

Bug Description

Property protections need to be enforced in the order specified by the configuration file. i.e. [^x_owner.*] should be enforced before [.*] given the example config.

This is currently not the case as the rules in property_utils.py is a dict.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-09-12: Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/46268

Changed in glance:
assignee:	nobody → Paul Bourke (pauldbourke)
status:	New → In Progress

Iccha Sethi (iccha-sethi) on 2013-09-12

Changed in glance:
importance:	Undecided → High
milestone:	none → havana-rc1

OpenStack Infra (hudson-openstack) on 2013-09-20

Changed in glance:
assignee:	Paul Bourke (pauldbourke) → Thomas Leaman (thomas-leaman)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-09-24: Fix merged to glance (master)

Reviewed: https://review.openstack.org/46268
Committed: http://github.com/openstack/glance/commit/49c69485e41d483abb18b689c65bd043b7a29695
Submitter: Jenkins
Branch: master

commit 49c69485e41d483abb18b689c65bd043b7a29695
Author: Paul Bourke <email address hidden>
Date: Thu Sep 12 12:52:10 2013 +0000

Ensure prop protections are read/enforced in order

    Property protections need to be enforced in the order specified by the
    configuration file. i.e. [^x_owner.*] should be enforced before [.*]
    given the example config.

    To achieve this, use a list of tuples to store the rules rather than a
    dict, and also ensure to specify dict_type when parsing the
    configuration file for python 2.6.

Fixes bug 1224449

Change-Id: Ib22cb34b7daef081c95717b55a991b8d613468c4