Don't use ModelBase.save() inside of block session.begin()
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Cinder |
Fix Released
|
Undecided
|
ChangBo Guo(gcb) | ||
OpenStack Compute (nova) |
Fix Released
|
Undecided
|
ChangBo Guo(gcb) | ||
Sahara |
Fix Released
|
Medium
|
ChangBo Guo(gcb) |
Bug Description
Current code use ModelBase.save() always submit a commit even inside a block fo with session.begin().
this is not purpose of using session.begin() to organize some operations in one transaction
1)session.begin() will return a SessionTransaction instance, then call SessionTransact
and do something in with block, then call SessionTransact
2) There is also suggestion metioned in https:/
3) ModelBase.save() begin another transaction see https:/
so we'd better don't use ModelBase.save() inside of block session.begin()
Changed in savanna: | |
assignee: | nobody → ChangBo Guo (guochbo) |
milestone: | none → 0.3a1 |
importance: | Undecided → Medium |
tags: | added: 0.3 |
Changed in nova: | |
milestone: | none → havana-rc1 |
Changed in savanna: | |
status: | Fix Committed → Fix Released |
Changed in nova: | |
status: | Fix Committed → Fix Released |
Changed in nova: | |
milestone: | havana-rc1 → 2013.2 |
Changed in savanna: | |
milestone: | 0.3a1 → 0.3 |
description: | updated |
Changed in cinder: | |
milestone: | none → juno-2 |
status: | Fix Committed → Fix Released |
Changed in cinder: | |
milestone: | juno-2 → 2014.2 |
Fix proposed to branch: master /review. openstack. org/46253
Review: https:/