F8 in tmux backend does not handle spaces correctly

[Chow Loong Jin]

  affects ubuntu/byobu

When hitting F8 and renaming the window with a space inside, the command throws
an error and doesn't actually rename the window. "C-b ," from tmux's default
config works correctly though.

From tmux's default config:
bind-key , command-prompt -I #W "rename-window '%%'"

Byobu's config:
bind-key F8 command-prompt -p (rename-window) "rename-window %%"

I'd suggest either using tmux's version, or surrounding %% in the Byobu version with ''.

--
Kind regards,
Loong Jin

[Dustin Kirkland  (kirkland)]

What version of Byobu are you running? I see that this is already fixed in trunk...

I did commit a small change, using the -I "#W" to show the current title.

[Chow Loong Jin (hyperair)]

On Thu, Sep 12, 2013 at 03:51:49PM -0000, Dustin Kirkland wrote:
> What version of Byobu are you running? I see that this is already fixed
> in trunk...

The one in raring:
byobu:
  Installed: 5.35-0ubuntu1
  Candidate: 5.35-0ubuntu1
  Version table:
 *** 5.35-0ubuntu1 0
        500 http://sg.archive.ubuntu.com/ubuntu/ raring/main amd64 Packages
        100 /var/lib/dpkg/status

> I did commit a small change, using the -I "#W" to show the current
> title.

Thanks.

--
Kind regards,
Loong Jin

[Launchpad Janitor (janitor)]

This bug was fixed in the package byobu - 5.58-0ubuntu1

---------------
byobu (5.58-0ubuntu1) saucy; urgency=low

  * usr/share/byobu/keybindings/f-keys.tmux,
    usr/share/byobu/keybindings/f-keys.tmux.disable,
    usr/share/byobu/keybindings/Makefile.am,
    usr/share/byobu/keybindings/mouse.tmux.disable,
    usr/share/byobu/keybindings/mouse.tmux.enable,
    usr/share/doc/byobu/help.tmux.txt:
    - add support for a new keybinding, Alt-F12, to toggle on/off
      tmux mouse support
    - display a message when toggling either on or off mouse or
      F-keys support
  * usr/share/byobu/keybindings/f-keys.screen,
    usr/share/byobu/keybindings/f-keys.screen.disable,
    usr/share/byobu/keybindings/f-keys.tmux,
    usr/share/byobu/keybindings/f-keys.tmux.disable,
    usr/share/doc/byobu/help.tmux.txt: LP: #1218680
    - byobu-screen has long supported Ctrl-A-~ which saves your scrollback
      buffer to a file
    - byobu-tmux had never quite implemented this
    - Add a new keybinding to both byobu-screen and byobu-tmux that adds
      this support, Shift-F9
  * usr/share/byobu/keybindings/f-keys.tmux: LP: #1224352
    - show current window name when prompting for rename-window
 -- Dustin Kirkland <email address hidden> Tue, 03 Sep 2013 14:40:09 -0500