no avatar in notification for call or message

Bug #1224095 reported by Bill Filler
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
telephony-service
Fix Released
High
Gustavo Pichorim Boiko
unity-notifications
Fix Released
Undecided
Unassigned
telephony-service (Ubuntu)
Fix Released
High
Gustavo Pichorim Boiko
Saucy
Fix Released
High
Gustavo Pichorim Boiko
unity-notifications (Ubuntu)
Fix Released
Undecided
Unassigned
Saucy
Fix Released
Undecided
Unassigned

Bug Description

send a text message or make an incoming call to the phone from a contact that has an avatar in your address book. The notification does not display the correct avatar. It shows an empty black box where the avatar should be.

Related branches

Bill Filler (bfiller)
Changed in dialer-app:
assignee: nobody → Gustavo Pichorim Boiko (boiko)
Changed in messaging-app:
assignee: nobody → Gustavo Pichorim Boiko (boiko)
Changed in dialer-app (Ubuntu):
assignee: nobody → Gustavo Pichorim Boiko (boiko)
Changed in dialer-app:
importance: Undecided → High
Changed in messaging-app:
importance: Undecided → High
Changed in dialer-app (Ubuntu):
importance: Undecided → High
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in dialer-app (Ubuntu):
status: New → Confirmed
Bill Filler (bfiller)
Changed in dialer-app:
status: New → Confirmed
Changed in messaging-app:
status: New → Confirmed
Changed in dialer-app:
assignee: Gustavo Pichorim Boiko (boiko) → Tiago Salem Herrmann (tiagosh)
Changed in messaging-app:
assignee: Gustavo Pichorim Boiko (boiko) → Tiago Salem Herrmann (tiagosh)
Changed in dialer-app (Ubuntu):
assignee: Gustavo Pichorim Boiko (boiko) → Tiago Salem Herrmann (tiagosh)
tags: added: dialer-app-sept-2013
Bill Filler (bfiller)
Changed in dialer-app (Ubuntu Saucy):
assignee: Tiago Salem Herrmann (tiagosh) → Gustavo Pichorim Boiko (boiko)
Changed in messaging-app:
assignee: Tiago Salem Herrmann (tiagosh) → Gustavo Pichorim Boiko (boiko)
Changed in dialer-app:
assignee: Tiago Salem Herrmann (tiagosh) → Gustavo Pichorim Boiko (boiko)
Revision history for this message
Michał Sawicz (saviq) wrote :

We've tracked down the issue to:

http://bazaar.launchpad.net/~unity-api-team/unity-notifications/trunk/view/head:/src/Notification.cpp#L130

Which only checks for a leading slash to figure out if it should prepend the path with "image://gicon/", which is wrong. It should probably check if there are *any* slashes, and use image://theme/ if there are none. Otherwise it should just pass the string through.

Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Also, there was one other problem: the contact avatar file path has a % and thus an encoding is required in the URL in order for it to arrive correctly on the other side.

affects: dialer-app → telephony-service
affects: dialer-app (Ubuntu Saucy) → telephony-service (Ubuntu Saucy)
no longer affects: messaging-app
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:telephony-service at revision 749, scheduled for release in telephony-service, milestone Unknown

Changed in telephony-service:
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package telephony-service - 0.1+13.10.20131001.4-0ubuntu1

---------------
telephony-service (0.1+13.10.20131001.4-0ubuntu1) saucy; urgency=low

  [ Gustavo Pichorim Boiko ]
  * Handle exceptions that might occur as a result of metric service
    usage.
  * Properly encode the contact avatar image path. (LP: #1224095)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 749
 -- Ubuntu daily release <email address hidden> Tue, 01 Oct 2013 21:20:46 +0000

Changed in telephony-service (Ubuntu Saucy):
status: Confirmed → Fix Released
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:unity-notifications at revision None, scheduled for release in unity-notifications, milestone Unknown

Changed in unity-notifications:
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity-notifications - 0.1.1+13.10.20131004.1-0ubuntu1

---------------
unity-notifications (0.1.1+13.10.20131004.1-0ubuntu1) saucy; urgency=low

  [ Michał Sawicz ]
  * Bump version to indicate support for passing hints through.
  * Look for *any* slashes, not just a leading one, to support URLs.
    Also drop an outdated FIXME. (LP: #1224095)

  [ Mirco Müller ]
  * Added support for new hints "x-canonical-private-menu-model" and "x-
    canonical-ext-snap-decisions" allowing to pass in UnityMenuModel UI-
    descriptions and enable extended snap-decisions.

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 175
 -- Ubuntu daily release <email address hidden> Fri, 04 Oct 2013 06:55:02 +0000

Changed in unity-notifications (Ubuntu Saucy):
status: New → Fix Released
Michał Sawicz (saviq)
Changed in telephony-service:
status: Fix Committed → Fix Released
Changed in unity-notifications:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.