Deleting display name does not remove it

[Kristina Hoeppner]

Tested on Mahara 1.7 and 1.8.0dev

When you provide a display name and then don't want to use it anymore, you cannot get rid of it.

To reproduce:

1. Enter a display name into your profile and save the profile.
2. The display name is shown in the login box in the right sidebar.
3. Delete the display name from your profile and save.
4. Expected behaviour: Your first and last name is shown again instead of the display name.
Actual behaviour: Your display name is still shown.

[Kristina Hoeppner (kris-hoeppner)]

Haven't tested on 1.5 and 1.6 yet.

[Son Nguyen (ngson2000)]

Hi Kristina;

Actually, the display name has been deleted. However, you need to re-login to see the first and last name.

[Son Nguyen (ngson2000)]

I will update the display name right after clicking the 'Save profile'

[Aaron Wells (u-aaronw)]

I've just confirmed the issue is also present in 1.5 and 1.6. Although since I think we've just done the final minor release for 1.5 it would probably be moot to backport it there.

[Son Nguyen (ngson2000)]

https://reviews.mahara.org/2583

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/2583
Committed: http://gitorious.org/mahara/mahara/commit/8f189300479c40e151e4c3f28d9c5a8866c62da9
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 8f189300479c40e151e4c3f28d9c5a8866c62da9
Author: Aaron Wells <email address hidden>
Date: Tue Oct 8 13:17:57 2013 +1300

Update session-cached display name when deleting it

Bug 1223063: ArtefactTypeCachedProfileField was only updating
the session cache when you updated a value, not when you deleted it.
Of course, the only one that can get deleted and that is shown
anywhere is the PreferredName (aka display name) so only this
one shows the problem.

Change-Id: I55f9c96b59c91ced5cba3cf6443ba2e222201ef7
Signed-off-by: Aaron Wells <email address hidden>

[Aaron Wells (u-aaronw)]

We know this also happens in 1.7, so the fix should be backported there.

We haven't tested whether it happens in 1.6, so we should test first, and then backport it if it is present.

Let's leave 1.5 alone for now, though, except for security fixes and regression fixes.

[Son Nguyen (ngson2000)]

https://reviews.mahara.org/2588 for 1.7
https://reviews.mahara.org/2589 for 1.6